From 4594bdc8eeb7bd879d215c16ed18c9223e99bc27 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Tue, 20 Oct 2020 17:46:47 -0700 Subject: [PATCH 01/30] Add static web app extension to recommendations --- .vscode/extensions.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 26786f9..3b73afd 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -1,5 +1,6 @@ { "recommendations": [ - "ms-azuretools.vscode-azurefunctions" + "ms-azuretools.vscode-azurefunctions", + "ms-azuretools.vscode-azurestaticwebapps" ] } From a19ddc48b9c0704d42e34d6ab3f5518ab94ab391 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Wed, 2 Dec 2020 23:26:12 +0000 Subject: [PATCH 02/30] tweak sample to make e2e scenarios easier to run --- api/.gitignore | 2 +- api/local.settings.json | 6 ++++++ installAzFunc.sh | 6 ++++++ 3 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 api/local.settings.json create mode 100755 installAzFunc.sh diff --git a/api/.gitignore b/api/.gitignore index 772851c..353e033 100644 --- a/api/.gitignore +++ b/api/.gitignore @@ -91,4 +91,4 @@ out bin obj appsettings.json -local.settings.json \ No newline at end of file +# local.settings.json \ No newline at end of file diff --git a/api/local.settings.json b/api/local.settings.json new file mode 100644 index 0000000..1b8e416 --- /dev/null +++ b/api/local.settings.json @@ -0,0 +1,6 @@ +{ + "IsEncrypted": false, + "Values": { + "FUNCTIONS_WORKER_RUNTIME": "node" + } +} \ No newline at end of file diff --git a/installAzFunc.sh b/installAzFunc.sh new file mode 100755 index 0000000..c5cc3b4 --- /dev/null +++ b/installAzFunc.sh @@ -0,0 +1,6 @@ +#!/bin/bash +curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg +sudo mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg +sudo sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/debian/$(lsb_release -rs | cut -d'.' -f 1)/prod $(lsb_release -cs) main" > /etc/apt/sources.list.d/dotnetdev.list' +sudo apt-get update +sudo apt-get install azure-functions-core-tools-3 From cbac05e8737c1a1705f77730b9d33a58f1e41d95 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Wed, 2 Dec 2020 23:26:39 +0000 Subject: [PATCH 03/30] remove devcontainer json --- .devcontainer/Dockerfile | 10 ---------- .devcontainer/devcontainer.json | 28 ---------------------------- 2 files changed, 38 deletions(-) delete mode 100644 .devcontainer/Dockerfile delete mode 100644 .devcontainer/devcontainer.json diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile deleted file mode 100644 index 7f30650..0000000 --- a/.devcontainer/Dockerfile +++ /dev/null @@ -1,10 +0,0 @@ -# Find the Dockerfile for mcr.microsoft.com/azure-functions/node at the following URLs: -# Node 10: https://github.com/Azure/azure-functions-docker/blob/master/host/3.0/buster/amd64/node/node10/node10-core-tools.Dockerfile -# Node 12: https://github.com/Azure/azure-functions-docker/blob/master/host/3.0/buster/amd64/node/node12/node12-core-tools.Dockerfile -ARG VARIANT=12 -FROM mcr.microsoft.com/azure-functions/node:3.0-node${VARIANT}-core-tools - -# [Optional] Uncomment this section to install additional OS packages. -# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \ -# && apt-get -y install --no-install-recommends - diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json deleted file mode 100644 index 89b1472..0000000 --- a/.devcontainer/devcontainer.json +++ /dev/null @@ -1,28 +0,0 @@ -{ - "name": "Azure Functions & Node.js", - "build": { - "dockerfile": "Dockerfile", - // Update 'VARIANT' to pick a Node.js version: 10, 12 - "args": { - "VARIANT": "12" - } - }, - "forwardPorts": [ - 7071, - 3000 - ], - // Set *default* container specific settings.json values on container create. - "settings": { - "terminal.integrated.shell.linux": "/bin/bash" - }, - // Add the IDs of extensions you want installed when the container is created. - "extensions": [ - "ms-azuretools.vscode-azurefunctions", - "ms-azuretools.vscode-azurestaticwebapps", - "dbaeumer.vscode-eslint" - ], - // Use 'postCreateCommand' to run commands after the container is created. - "postCreateCommand": "npm install", - // Uncomment to connect as a non-root user. See https://aka.ms/vscode-remote/containers/non-root. - "remoteUser": "node" -} \ No newline at end of file From c6d0b010e7d9015a809bec5a5faa354f2d7d4720 Mon Sep 17 00:00:00 2001 From: chrisdias Date: Fri, 4 Dec 2020 12:55:06 -0800 Subject: [PATCH 04/30] eliminate azure function --- .vscode/extensions.json | 6 -- .vscode/launch.json | 10 ++-- .vscode/settings.json | 8 --- .vscode/tasks.json | 32 ---------- api/.funcignore | 7 --- api/.gitignore | 94 ------------------------------ api/GetProducts/function.json | 19 ------ api/GetProducts/index.js | 8 --- api/GetProducts/sample.dat | 3 - api/host.json | 15 ----- api/local.settings.json | 6 -- api/package-lock.json | 5 -- api/package.json | 11 ---- api/proxies.json | 4 -- installAzFunc.sh | 6 -- package-lock.json | 8 --- package.json | 7 ++- {api/data => server}/products.json | 0 server/server.js | 13 +++++ src/App.js | 6 +- 20 files changed, 25 insertions(+), 243 deletions(-) delete mode 100644 .vscode/extensions.json delete mode 100644 .vscode/settings.json delete mode 100644 .vscode/tasks.json delete mode 100644 api/.funcignore delete mode 100644 api/.gitignore delete mode 100644 api/GetProducts/function.json delete mode 100644 api/GetProducts/index.js delete mode 100644 api/GetProducts/sample.dat delete mode 100644 api/host.json delete mode 100644 api/local.settings.json delete mode 100644 api/package-lock.json delete mode 100644 api/package.json delete mode 100644 api/proxies.json delete mode 100755 installAzFunc.sh rename {api/data => server}/products.json (100%) create mode 100644 server/server.js diff --git a/.vscode/extensions.json b/.vscode/extensions.json deleted file mode 100644 index 3b73afd..0000000 --- a/.vscode/extensions.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "recommendations": [ - "ms-azuretools.vscode-azurefunctions", - "ms-azuretools.vscode-azurestaticwebapps" - ] -} diff --git a/.vscode/launch.json b/.vscode/launch.json index e7be044..55d614a 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -2,11 +2,11 @@ "version": "0.2.0", "configurations": [ { - "name": "Attach to Node Functions", - "type": "node", - "request": "attach", - "port": 9229, - "preLaunchTask": "func: host start" + "name": "Launch Chrome", + "request": "launch", + "type": "pwa-chrome", + "url": "http://localhost:3000", + "webRoot": "${workspaceFolder}" } ] } \ No newline at end of file diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index bc8c902..0000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "azureFunctions.deploySubpath": "api", - "azureFunctions.postDeployTask": "npm install", - "azureFunctions.projectLanguage": "JavaScript", - "azureFunctions.projectRuntime": "~3", - "debug.internalConsoleOptions": "neverOpen", - "azureFunctions.preDeployTask": "npm prune" -} \ No newline at end of file diff --git a/.vscode/tasks.json b/.vscode/tasks.json deleted file mode 100644 index e78ad55..0000000 --- a/.vscode/tasks.json +++ /dev/null @@ -1,32 +0,0 @@ -{ - "version": "2.0.0", - "tasks": [ - { - "type": "func", - "command": "host start", - "problemMatcher": "$func-watch", - "isBackground": true, - "dependsOn": "npm install", - "options": { - "cwd": "${workspaceFolder}/api" - } - }, - { - "type": "shell", - "label": "npm install", - "command": "npm install", - "options": { - "cwd": "${workspaceFolder}/api" - } - }, - { - "type": "shell", - "label": "npm prune", - "command": "npm prune --production", - "problemMatcher": [], - "options": { - "cwd": "${workspaceFolder}/api" - } - } - ] -} \ No newline at end of file diff --git a/api/.funcignore b/api/.funcignore deleted file mode 100644 index 5179222..0000000 --- a/api/.funcignore +++ /dev/null @@ -1,7 +0,0 @@ -*.js.map -*.ts -.git* -.vscode -local.settings.json -test -tsconfig.json \ No newline at end of file diff --git a/api/.gitignore b/api/.gitignore deleted file mode 100644 index 353e033..0000000 --- a/api/.gitignore +++ /dev/null @@ -1,94 +0,0 @@ -# Logs -logs -*.log -npm-debug.log* -yarn-debug.log* -yarn-error.log* -lerna-debug.log* - -# Diagnostic reports (https://nodejs.org/api/report.html) -report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json - -# Runtime data -pids -*.pid -*.seed -*.pid.lock - -# Directory for instrumented libs generated by jscoverage/JSCover -lib-cov - -# Coverage directory used by tools like istanbul -coverage - -# nyc test coverage -.nyc_output - -# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files) -.grunt - -# Bower dependency directory (https://bower.io/) -bower_components - -# node-waf configuration -.lock-wscript - -# Compiled binary addons (https://nodejs.org/api/addons.html) -build/Release - -# Dependency directories -node_modules/ -jspm_packages/ - -# TypeScript v1 declaration files -typings/ - -# Optional npm cache directory -.npm - -# Optional eslint cache -.eslintcache - -# Optional REPL history -.node_repl_history - -# Output of 'npm pack' -*.tgz - -# Yarn Integrity file -.yarn-integrity - -# dotenv environment variables file -.env -.env.test - -# parcel-bundler cache (https://parceljs.org/) -.cache - -# next.js build output -.next - -# nuxt.js build output -.nuxt - -# vuepress build output -.vuepress/dist - -# Serverless directories -.serverless/ - -# FuseBox cache -.fusebox/ - -# DynamoDB Local files -.dynamodb/ - -# TypeScript output -dist -out - -# Azure Functions artifacts -bin -obj -appsettings.json -# local.settings.json \ No newline at end of file diff --git a/api/GetProducts/function.json b/api/GetProducts/function.json deleted file mode 100644 index 72a6566..0000000 --- a/api/GetProducts/function.json +++ /dev/null @@ -1,19 +0,0 @@ -{ - "bindings": [ - { - "authLevel": "anonymous", - "type": "httpTrigger", - "direction": "in", - "name": "req", - "methods": [ - "get" - ], - "route": "products" - }, - { - "type": "http", - "direction": "out", - "name": "res" - } - ] -} \ No newline at end of file diff --git a/api/GetProducts/index.js b/api/GetProducts/index.js deleted file mode 100644 index f290034..0000000 --- a/api/GetProducts/index.js +++ /dev/null @@ -1,8 +0,0 @@ -const products = require("../data/products.json"); - -module.exports = async function (context, req) { - context.res = { - // status: 200, /* Defaults to 200 */ - body: products - }; -} \ No newline at end of file diff --git a/api/GetProducts/sample.dat b/api/GetProducts/sample.dat deleted file mode 100644 index 2e60943..0000000 --- a/api/GetProducts/sample.dat +++ /dev/null @@ -1,3 +0,0 @@ -{ - "name": "Azure" -} \ No newline at end of file diff --git a/api/host.json b/api/host.json deleted file mode 100644 index 6ab6643..0000000 --- a/api/host.json +++ /dev/null @@ -1,15 +0,0 @@ -{ - "version": "2.0", - "logging": { - "applicationInsights": { - "samplingSettings": { - "isEnabled": true, - "excludedTypes": "Request" - } - } - }, - "extensionBundle": { - "id": "Microsoft.Azure.Functions.ExtensionBundle", - "version": "[1.*, 2.0.0)" - } -} diff --git a/api/local.settings.json b/api/local.settings.json deleted file mode 100644 index 1b8e416..0000000 --- a/api/local.settings.json +++ /dev/null @@ -1,6 +0,0 @@ -{ - "IsEncrypted": false, - "Values": { - "FUNCTIONS_WORKER_RUNTIME": "node" - } -} \ No newline at end of file diff --git a/api/package-lock.json b/api/package-lock.json deleted file mode 100644 index 0bb6c76..0000000 --- a/api/package-lock.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "name": "api", - "version": "1.0.0", - "lockfileVersion": 1 -} diff --git a/api/package.json b/api/package.json deleted file mode 100644 index 10f08ee..0000000 --- a/api/package.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "name": "api", - "version": "1.0.0", - "description": "", - "scripts": { - "start": "func start", - "test": "echo \"No tests yet...\"" - }, - "dependencies": {}, - "devDependencies": {} -} diff --git a/api/proxies.json b/api/proxies.json deleted file mode 100644 index b385252..0000000 --- a/api/proxies.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "$schema": "http://json.schemastore.org/proxies", - "proxies": {} -} diff --git a/installAzFunc.sh b/installAzFunc.sh deleted file mode 100755 index c5cc3b4..0000000 --- a/installAzFunc.sh +++ /dev/null @@ -1,6 +0,0 @@ -#!/bin/bash -curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor > microsoft.gpg -sudo mv microsoft.gpg /etc/apt/trusted.gpg.d/microsoft.gpg -sudo sh -c 'echo "deb [arch=amd64] https://packages.microsoft.com/debian/$(lsb_release -rs | cut -d'.' -f 1)/prod $(lsb_release -cs) main" > /etc/apt/sources.list.d/dotnetdev.list' -sudo apt-get update -sudo apt-get install azure-functions-core-tools-3 diff --git a/package-lock.json b/package-lock.json index d3e9200..43bb051 100644 --- a/package-lock.json +++ b/package-lock.json @@ -2554,14 +2554,6 @@ "resolved": "https://registry.npmjs.org/aws4/-/aws4-1.10.1.tgz", "integrity": "sha512-zg7Hz2k5lI8kb7U32998pRRFin7zJlkfezGJjUc2heaD4Pw2wObakCDVzkKztTm/Ln7eiVvYsjqak0Ed4LkMDA==" }, - "axios": { - "version": "0.20.0", - "resolved": "https://registry.npmjs.org/axios/-/axios-0.20.0.tgz", - "integrity": "sha512-ANA4rr2BDcmmAQLOKft2fufrtuvlqR+cXNNinUmvfeSNCOF98PZL+7M/v1zIdGo7OLjEA9J2gXJL+j4zGsl0bA==", - "requires": { - "follow-redirects": "^1.10.0" - } - }, "axobject-query": { "version": "2.2.0", "resolved": "https://registry.npmjs.org/axobject-query/-/axobject-query-2.2.0.tgz", diff --git a/package.json b/package.json index 13472ce..abb129e 100644 --- a/package.json +++ b/package.json @@ -6,15 +6,16 @@ "@testing-library/jest-dom": "^4.2.4", "@testing-library/react": "^9.5.0", "@testing-library/user-event": "^7.2.1", - "axios": "^0.20.0", "bulma": "^0.9.1", "node-sass": "^4.14.1", "react": "^16.14.0", "react-dom": "^16.14.0", - "react-scripts": "3.4.3" + "react-scripts": "3.4.3", + "express": "4.17.1" }, "scripts": { "start": "react-scripts start", + "server": "node ./server/server.js", "build": "react-scripts build", "test": "react-scripts test", "eject": "react-scripts eject" @@ -34,5 +35,5 @@ "last 1 safari version" ] }, - "proxy": "http://localhost:7071" + "proxy": "http://localhost:3005" } diff --git a/api/data/products.json b/server/products.json similarity index 100% rename from api/data/products.json rename to server/products.json diff --git a/server/server.js b/server/server.js new file mode 100644 index 0000000..9146e08 --- /dev/null +++ b/server/server.js @@ -0,0 +1,13 @@ +const express = require('express'); +const products = require("./products.json"); + +const app = express(); + +app.use('/GetProducts', function(req, res, next) { + res.send(products); +}) + +app.listen(3005, function() { + console.log('server listening on http://localhost:3005'); +}); + diff --git a/src/App.js b/src/App.js index 8986ab0..cface80 100644 --- a/src/App.js +++ b/src/App.js @@ -1,5 +1,4 @@ import React, { useEffect, useState } from 'react'; -import axios from 'axios'; const App = () => { const [products, setProducts] = useState([]); @@ -7,12 +6,13 @@ const App = () => { useEffect(() => { async function getProducts() { - const response = await axios.get('api/products'); - setProducts(response.data); + const response = await fetch('/GetProducts').then(res => res.json()); + setProducts(response); setLoading(false); } getProducts(); + }, []) return ( From 1e6b8eca49b05111a9a77c0f7f713e75c0ff2190 Mon Sep 17 00:00:00 2001 From: chrisdias Date: Fri, 4 Dec 2020 14:24:56 -0800 Subject: [PATCH 05/30] update launch.json --- .vscode/launch.json | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.vscode/launch.json b/.vscode/launch.json index 55d614a..573bd0d 100644 --- a/.vscode/launch.json +++ b/.vscode/launch.json @@ -2,7 +2,21 @@ "version": "0.2.0", "configurations": [ { - "name": "Launch Chrome", + "type": "node", + "request": "launch", + "name": "Launch Server", + "runtimeExecutable": "npm", + "runtimeArgs": [ + "run-script", + "server" + ], + "port": 9229, + "skipFiles": [ + "/**" + ] + }, + { + "name": "Launch Chrome (Desktop Only)", "request": "launch", "type": "pwa-chrome", "url": "http://localhost:3000", From 9c25dbe450826e73aab9bb26717295de78940fae Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Fri, 11 Dec 2020 04:35:02 +0000 Subject: [PATCH 06/30] add scenario status page --- scenarioStatus.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 scenarioStatus.md diff --git a/scenarioStatus.md b/scenarioStatus.md new file mode 100644 index 0000000..6b47b4c --- /dev/null +++ b/scenarioStatus.md @@ -0,0 +1,21 @@ +## Scenario Status + +### Legend + +| Status | Definition | +| ---- | ---- | +|🔴| Blocking | +|🟢| Passing | +|🟡| Issue, but not blocking | + +### Status + +| Date | Extension | Get the Repo | Install Extensions | Install Az Func Tools | Run Client | Run Server | Port Forwarding | Debugging | +| ---- | ---- | ---- | ---- | ---- | ---- | ---- | ---- | ---- | +| 10/20/20 | n/a |:yellow_circle:|:green_circle:|:yellow_circle:|:green_circle:|:red_circle: https://github.com/github/codespaces/issues/1435
workaround: run `func host start` from the `api` folder |:green_circle:|:red_circle: https://github.com/github/codespaces/issues/1435 | +| 11/24/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/Azure/Azure-Functions/issues/1454 | | | +| 12/1/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/Azure/Azure-Functions/issues/1454 / https://github.com/microsoft/vssaas-planning/issues/1518#issuecomment-736834342 | | | +| 12/2/20 | n/a |:green_circle:|:green_circle:|:yellow_circle:|:green_circle:|:red_circle: https://github.com/Azure/Azure-Functions/issues/1454 / https://github.com/microsoft/vssaas-planning/issues/1518#issuecomment-736834342 | | | +| 12/2/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:| +:red +| 12/10/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/microsoft/vscode-internalbacklog/issues/1680 \ No newline at end of file From 85ee3842f1ed16966638cad969e2b2bd34f67c6f Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Fri, 18 Dec 2020 02:16:01 +0000 Subject: [PATCH 07/30] updated scenario status with 12/17 run --- scenarioStatus.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scenarioStatus.md b/scenarioStatus.md index 6b47b4c..f7dff2d 100644 --- a/scenarioStatus.md +++ b/scenarioStatus.md @@ -18,4 +18,5 @@ | 12/2/20 | n/a |:green_circle:|:green_circle:|:yellow_circle:|:green_circle:|:red_circle: https://github.com/Azure/Azure-Functions/issues/1454 / https://github.com/microsoft/vssaas-planning/issues/1518#issuecomment-736834342 | | | | 12/2/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:| :red -| 12/10/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/microsoft/vscode-internalbacklog/issues/1680 \ No newline at end of file +| 12/10/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/microsoft/vscode-internalbacklog/issues/1680 +| 12/17/20 | n/a |:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:green_circle:|:red_circle: https://github.com/microsoft/vscode-internalbacklog/issues/1680 \ No newline at end of file From 0e3fad346676eeb7f22100d298af6f5a511e2672 Mon Sep 17 00:00:00 2001 From: Burke Holland Date: Thu, 21 Jan 2021 15:56:43 +0000 Subject: [PATCH 08/30] Add a totally useful logging statement --- server/server.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/server/server.js b/server/server.js index 9146e08..90f6eed 100644 --- a/server/server.js +++ b/server/server.js @@ -4,6 +4,9 @@ const products = require("./products.json"); const app = express(); app.use('/GetProducts', function(req, res, next) { + // get products from db + console.log("Getting products...") + res.send(products); }) From 211f3d548389ffcd3333cb282be69a9ed98f8e65 Mon Sep 17 00:00:00 2001 From: burkeholland Date: Thu, 21 Jan 2021 16:17:02 +0000 Subject: [PATCH 09/30] add more logging --- server/server.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/server.js b/server/server.js index 9146e08..3d723db 100644 --- a/server/server.js +++ b/server/server.js @@ -8,6 +8,10 @@ app.use('/GetProducts', function(req, res, next) { }) app.listen(3005, function() { + + // listening on a port + console.log("server is listening"); + console.log('server listening on http://localhost:3005'); }); From 390baa7c43d4d6c387ece64629bb6ce7b0d6a06d Mon Sep 17 00:00:00 2001 From: Burke Holland Date: Tue, 26 Jan 2021 16:58:58 +0000 Subject: [PATCH 10/30] remove logging --- server/server.js | 3 --- 1 file changed, 3 deletions(-) diff --git a/server/server.js b/server/server.js index 24fbfae..3d723db 100644 --- a/server/server.js +++ b/server/server.js @@ -4,9 +4,6 @@ const products = require("./products.json"); const app = express(); app.use('/GetProducts', function(req, res, next) { - // get products from db - console.log("Getting products...") - res.send(products); }) From d33d68791354ac0f571f68faf691c9064aaa0695 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Tue, 9 Feb 2021 17:21:30 +0000 Subject: [PATCH 11/30] comment out unnecessary code --- server/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.js b/server/server.js index 3d723db..c4fd113 100644 --- a/server/server.js +++ b/server/server.js @@ -10,7 +10,7 @@ app.use('/GetProducts', function(req, res, next) { app.listen(3005, function() { // listening on a port - console.log("server is listening"); + // console.log("server is listening"); console.log('server listening on http://localhost:3005'); }); From ae99143be361160de0fc5e5cf51542bfd4da9d03 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Thu, 18 Feb 2021 00:20:23 +0000 Subject: [PATCH 12/30] Update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 54ef094..6258427 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console. +You will also see any lint errors in the console! ### `npm test` From 42cec7c3c54e6e299954dfad7d097bb6e78d4e93 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Wed, 24 Feb 2021 22:04:09 +0000 Subject: [PATCH 13/30] Update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6258427..54ef094 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console! +You will also see any lint errors in the console. ### `npm test` From 6e06ea2da82c273cd3002094ae27e4983c14a5ed Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Wed, 24 Feb 2021 22:47:41 +0000 Subject: [PATCH 14/30] Update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 54ef094..6258427 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console. +You will also see any lint errors in the console! ### `npm test` From 10e497cf7a13cb860bda39695cd3493b39e93996 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Thu, 25 Feb 2021 09:47:40 -0800 Subject: [PATCH 15/30] CHRIS --- server/server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/server/server.js b/server/server.js index c4fd113..5645cc9 100644 --- a/server/server.js +++ b/server/server.js @@ -5,6 +5,7 @@ const app = express(); app.use('/GetProducts', function(req, res, next) { res.send(products); + // STUFF }) app.listen(3005, function() { From 6da7fbe2ee5cc23300fb3c69a82bff778a15d8b8 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Fri, 26 Feb 2021 11:17:07 -0800 Subject: [PATCH 16/30] chris --- server/server.js | 1 - 1 file changed, 1 deletion(-) diff --git a/server/server.js b/server/server.js index 5645cc9..c4fd113 100644 --- a/server/server.js +++ b/server/server.js @@ -5,7 +5,6 @@ const app = express(); app.use('/GetProducts', function(req, res, next) { res.send(products); - // STUFF }) app.listen(3005, function() { From 3e1c3748bc56e9bffb3f8a555e3f2462bbaa356b Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Sun, 28 Feb 2021 16:24:01 -0800 Subject: [PATCH 17/30] demo --- server/server.js | 1 + 1 file changed, 1 insertion(+) diff --git a/server/server.js b/server/server.js index c4fd113..7cd6a08 100644 --- a/server/server.js +++ b/server/server.js @@ -5,6 +5,7 @@ const app = express(); app.use('/GetProducts', function(req, res, next) { res.send(products); + // test }) app.listen(3005, function() { From 3ac95415e29f8108a7264d7f1fa42456df0c5342 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Thu, 4 Mar 2021 01:07:45 +0000 Subject: [PATCH 18/30] Update readme! --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6258427..54ef094 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console! +You will also see any lint errors in the console. ### `npm test` From c8b3ced19bb2b9f1f5fc19d580a3f193ca76964c Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Thu, 11 Mar 2021 01:59:20 +0000 Subject: [PATCH 19/30] Update readme for run --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 54ef094..6258427 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console. +You will also see any lint errors in the console! ### `npm test` From 9274aafd94a8a4c4090824c5b4aa651c774bab8b Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Fri, 12 Mar 2021 17:03:26 +0000 Subject: [PATCH 20/30] Testing readme change --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6258427..54ef094 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console! +You will also see any lint errors in the console. ### `npm test` From 496cc855c8282899168b91cda92ef7d4479204dc Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Thu, 18 Mar 2021 16:18:27 +0000 Subject: [PATCH 21/30] Update readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 54ef094..6258427 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console. +You will also see any lint errors in the console! ### `npm test` From 65b79bc352196d5cfdc7eb2dbd064d1f71dcdc49 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Thu, 25 Mar 2021 19:31:08 +0000 Subject: [PATCH 22/30] Update readme for golden --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6258427..54ef094 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ Runs the app in the development mode.
Open [http://localhost:3000](http://localhost:3000) to view it in the browser. The page will reload if you make edits.
-You will also see any lint errors in the console! +You will also see any lint errors in the console. ### `npm test` From 9e5b9a75b98115412b2e82022e8b533a3c2b1933 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Tue, 11 May 2021 10:22:28 -0700 Subject: [PATCH 23/30] make changes --- src/App.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/App.js b/src/App.js index cface80..f374f15 100644 --- a/src/App.js +++ b/src/App.js @@ -11,6 +11,8 @@ const App = () => { setLoading(false); } + // comments + getProducts(); }, []) From 9d2dbf5900491c95d42caa6aef103b9bf5bedf57 Mon Sep 17 00:00:00 2001 From: Burke Holland Date: Fri, 11 Jun 2021 20:34:51 +0000 Subject: [PATCH 24/30] Add logging --- server/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.js b/server/server.js index 7cd6a08..c27ebc7 100644 --- a/server/server.js +++ b/server/server.js @@ -11,7 +11,7 @@ app.use('/GetProducts', function(req, res, next) { app.listen(3005, function() { // listening on a port - // console.log("server is listening"); + console.log("server is listening"); console.log('server listening on http://localhost:3005'); }); From 2ccb46e3d6505da6c3e14303d5cfa0f0d8b04659 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Fri, 11 Jun 2021 23:24:26 +0000 Subject: [PATCH 25/30] Punctuation --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 54ef094..4ea9541 100644 --- a/README.md +++ b/README.md @@ -25,7 +25,7 @@ It correctly bundles React in production mode and optimizes the build for the be The build is minified and the filenames include the hashes.
Your app is ready to be deployed! -See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information. +See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information! ### `npm run eject` From 2ce00c759a9a2c79b636a434ff9f82003d1398be Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Fri, 11 Jun 2021 23:35:40 +0000 Subject: [PATCH 26/30] Update --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4ea9541..809de63 100644 --- a/README.md +++ b/README.md @@ -23,9 +23,9 @@ Builds the app for production to the `build` folder.
It correctly bundles React in production mode and optimizes the build for the best performance. The build is minified and the filenames include the hashes.
-Your app is ready to be deployed! +Your app is ready to be deployed. -See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information! +See the section about [deployment](https://facebook.github.io/create-react-app/docs/deployment) for more information ### `npm run eject` From f2c28e251e8804313543e514306ccc5caa4dc4d7 Mon Sep 17 00:00:00 2001 From: Brigit Murtaugh Date: Fri, 11 Jun 2021 23:35:58 +0000 Subject: [PATCH 27/30] Another update --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 809de63..eeb140b 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ To learn React, check out the [React documentation](https://reactjs.org/). ### Code Splitting -This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting +This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting. ### Analyzing the Bundle Size From 8d44a155b18ed4f0941aacb96b4775cfe0b9a819 Mon Sep 17 00:00:00 2001 From: Burke Holland Date: Sat, 12 Jun 2021 17:19:48 +0000 Subject: [PATCH 28/30] Remove logging --- server/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.js b/server/server.js index c27ebc7..7cd6a08 100644 --- a/server/server.js +++ b/server/server.js @@ -11,7 +11,7 @@ app.use('/GetProducts', function(req, res, next) { app.listen(3005, function() { // listening on a port - console.log("server is listening"); + // console.log("server is listening"); console.log('server listening on http://localhost:3005'); }); From 2e68c6d886b10be4ce8c2ee450e09975af462525 Mon Sep 17 00:00:00 2001 From: Chris Dias Date: Mon, 12 Jul 2021 18:05:33 -0700 Subject: [PATCH 29/30] chris --- server/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.js b/server/server.js index 7cd6a08..c27ebc7 100644 --- a/server/server.js +++ b/server/server.js @@ -11,7 +11,7 @@ app.use('/GetProducts', function(req, res, next) { app.listen(3005, function() { // listening on a port - // console.log("server is listening"); + console.log("server is listening"); console.log('server listening on http://localhost:3005'); }); From 7e37f40138d5a2a210f0233a6217928d1f5e4805 Mon Sep 17 00:00:00 2001 From: Burke Holland Date: Sun, 18 Jul 2021 21:57:24 +0000 Subject: [PATCH 30/30] make a doc change --- server/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/server.js b/server/server.js index c27ebc7..7cd6a08 100644 --- a/server/server.js +++ b/server/server.js @@ -11,7 +11,7 @@ app.use('/GetProducts', function(req, res, next) { app.listen(3005, function() { // listening on a port - console.log("server is listening"); + // console.log("server is listening"); console.log('server listening on http://localhost:3005'); });