From daa3d0a9cd7a8487a0efa41859bebfc4def60608 Mon Sep 17 00:00:00 2001 From: Daniel Rossi Date: Thu, 13 Mar 2014 20:04:19 +1100 Subject: [PATCH 1/3] - #204 start offset does not need to be taken off the buffer offset when using offset and duration this caused issues. --- .../org/flowplayer/httpstreaming/HttpStreamingProvider.as | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plugins/httpstreaming/src/actionscript/org/flowplayer/httpstreaming/HttpStreamingProvider.as b/plugins/httpstreaming/src/actionscript/org/flowplayer/httpstreaming/HttpStreamingProvider.as index 512cc2a..34ee0e0 100644 --- a/plugins/httpstreaming/src/actionscript/org/flowplayer/httpstreaming/HttpStreamingProvider.as +++ b/plugins/httpstreaming/src/actionscript/org/flowplayer/httpstreaming/HttpStreamingProvider.as @@ -297,7 +297,8 @@ package org.flowplayer.httpstreaming { override public function get bufferStart():Number { if (! clip) return 0; - return _bufferStart - clip.start; + //#204 start offset does not need to be taken off the buffer offset when using offset and duration this caused issues. + return _bufferStart; } override public function get bufferEnd() : Number { From 38e80e0ed329e5ac9d503ca2ccd8ff5f7db0393c Mon Sep 17 00:00:00 2001 From: Daniel Rossi Date: Thu, 13 Mar 2014 22:40:58 +1100 Subject: [PATCH 2/3] - reverting weak references to animation engine events due to early garbage collection. Caused from memory leak fixes. May not be a problem leaving it up to the garbage collector. --- core/src/actionscript/org/flowplayer/view/AnimationEngine.as | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/src/actionscript/org/flowplayer/view/AnimationEngine.as b/core/src/actionscript/org/flowplayer/view/AnimationEngine.as index 78bf7f5..2e5d298 100644 --- a/core/src/actionscript/org/flowplayer/view/AnimationEngine.as +++ b/core/src/actionscript/org/flowplayer/view/AnimationEngine.as @@ -337,12 +337,12 @@ package org.flowplayer.view { playable.addEventListener(GoEvent.COMPLETE, function(event:GoEvent):void { onComplete(view, playable, completeCallback); - }, false, 0, true); + }); if (updateCallback != null) { playable.addEventListener(GoEvent.UPDATE, function(event:GoEvent):void { updateCallback(view); - }, false, 0, true); + }); } playable.start(); From 53d8c7efbdb022b2f3d2af9b357428bc499496a1 Mon Sep 17 00:00:00 2001 From: Daniel Rossi Date: Sat, 12 Apr 2014 06:59:30 +1000 Subject: [PATCH 3/3] - stage video render event sometimes does not dispatch therefore the mask is not setup correctly for display. move the listener earlier. possibly do not need this event and dispatch the clip event directly. --- .../actionscript/org/flowplayer/view/StageVideoWrapper.as | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/core/src/actionscript/org/flowplayer/view/StageVideoWrapper.as b/core/src/actionscript/org/flowplayer/view/StageVideoWrapper.as index ce37fab..05fef42 100644 --- a/core/src/actionscript/org/flowplayer/view/StageVideoWrapper.as +++ b/core/src/actionscript/org/flowplayer/view/StageVideoWrapper.as @@ -96,6 +96,7 @@ package org.flowplayer.view { if ( _hasStageVideo && _stage.stageVideos.length ) { _stageVideo = _stage.stageVideos[0]; + _stageVideo.addEventListener(StageVideoEvent.RENDER_STATE, _displayStageVideo); super.visible = false; //#503 update viewport when stage is added to obtain the coordnates correctly. _updateStageVideo(); @@ -103,7 +104,7 @@ package org.flowplayer.view { super.visible = true; _hasStageVideo = false; } - + attachNetStream(_netStream); } @@ -111,10 +112,7 @@ package org.flowplayer.view { _netStream = netStream; if ( hasStageVideo ) { log.info("Attaching netstream to stageVideo"); - - stageVideo.attachNetStream(_netStream); - stageVideo.addEventListener(StageVideoEvent.RENDER_STATE, _displayStageVideo); - + _stageVideo.attachNetStream(_netStream); } else { log.info("Attaching netstream to video");