Crashes X-Plane when loading PDF files

[Vantskruv]

Crashes when opening PDF files in Linux.
https://forums.x-plane.org/forums/topic/337151-arch-linux-avitab-ctd-when-open-pdf-files/

Running X-Plane beneath GDB, I get this result:

Thread 64 "Main Thread" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7ffee7fff6c0 (LWP 6690)] 0x00007ffee0005a10 in ?? () (gdb) up Downloading 22.10 K source file /usr/src/debug/lcms2/lcms2-2.17/src/cmserr.c #1 0x00007fffe8c398b8 in cmsSignalError (ContextID=ContextID@entry=0x0, ErrorCode=ErrorCode@entry=5, ErrorText=ErrorText@entry=0x7fffe8c75d58 "Couldn't allocate %ld bytes for profile") at /usr/src/debug/lcms2/lcms2-2.17/src/cmserr.c:524 524 lhg ->LogErrorHandler(ContextID, ErrorCode, Buffer); (gdb) up Downloading 61.35 K source file /usr/src/debug/lcms2/lcms2-2.17/src/cmsio0.c #2 0x00007fffe8c3b5a4 in cmsOpenIOhandlerFromMem (ContextID=ContextID@entry=0x0, Buffer=Buffer@entry=0x7ffee0005a10, size=size@entry=3861646912, AccessMode=AccessMode@entry=0x7fffe8c75146 "r") at /usr/src/debug/lcms2/lcms2-2.17/src/cmsio0.c:264 264 cmsSignalError(ContextID, cmsERROR_READ, "Couldn't allocate %ld bytes for profile", (long) size); (gdb) up #3 0x00007fffe8c3f8fc in cmsOpenProfileFromMemTHR (ContextID=0x0, MemPtr=0x7ffee0005a10, dwSize=3861646912) at /usr/src/debug/lcms2/lcms2-2.17/src/cmsio0.c:1283 1283 NewIcc ->IOhandler = cmsOpenIOhandlerFromMem(ContextID, (void*) MemPtr, dwSize, "r"); (gdb) up #4 0x00007ffee5d8f568 in fz_new_icc_profile () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #5 0x00007ffee5d0d403 in fz_new_icc_colorspace () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #6 0x00007ffee5d0d8f3 in fz_new_colorspace_context () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #7 0x00007ffee5d100c2 in fz_new_context_imp () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #8 0x00007ffee5bd761e in img::Rasterizer::initFitz() () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #9 0x00007ffee5bd86cc in img::Rasterizer::Rasterizer(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #10 0x00007ffee5ba9c20 in maps::DocumentSource::DocumentSource(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #11 0x00007ffee5bac3f5 in maps::LocalFileSource::LocalFileSource(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::shared_ptr<apis::ChartService>) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #12 0x00007ffee5ace60f in avitab::DocumentsApp::loadFile(std::shared_ptr<avitab::DocumentsApp::DocumentPage>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #13 0x00007ffee5ad112a in avitab::DocumentsApp::createDocumentTab(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #14 0x00007ffee5ad1834 in avitab::DocumentsApp::onSelect(int) () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #15 0x00007ffee5a887b1 in avitab::LVGLToolkit::guiLoop() () from /media/ntfsevo2/Spel/X-Plane 12/X-Plane 12/Resources/plugins/AviTab/lin_x64/AviTab.xpl (gdb) up #16 0x00007fffe9ae55a4 in std::execute_native_thread_routine (__p=0xb53fef0) at /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc:104 warning: 104 /usr/src/debug/gcc/gcc/libstdc++-v3/src/c++11/thread.cc: No such file or directory (gdb) up Downloading 34.87 K source file /usr/src/debug/glibc/glibc/nptl/pthread_create.c #17 0x00007fffe9e9698b in start_thread (arg=<optimized out>) at pthread_create.c:448 448 ret = pd->start_routine (pd->arg); (gdb) up Downloading 2.48 K source file /usr/src/debug/glibc/glibc/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S #18 0x00007fffe9f1a9cc in __GI___clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:78 78 call *%rdx /* Call function. */ (gdb) up Initial frame selected; you cannot go up. (gdb)

No significant errors in log files.

Avitab version 0.7.1
X-Plane 12.3.0-r3-c0eef4da

EndeavourOS
KDE Plasma Version: 6.5.3
KDE Frameworks Version: 6.20.0
Qt Version: 6.10.0
Kernel Version: 6.12.58-1-lts (64-bit)
Graphics Platform: X11

[Vantskruv]

I have successfully compiled AviTab on Linux (it generates a slightly bigger file than the original, 26.1 MB).
Still though, it crashes X-Plane in the same way when loading a PDF-file in the sim.

However, using the AviTab-standalone executable outside X-Plane, the plugin does not crash, and works as intended, succesfully loading and showing a .PDF-file.

[Vantskruv]

I succesfully compiled AviTab with a new version of mupdf, and now there are no crashes.
So I hope @fpw can update to use a more recent version of mupdf?

There is some changes to be made.

Edit lib/libgeotiff/libgeotiff/CMakeLists.txt by commenting out:

if (CMAKE_MAJOR_VERSION GREATER 2)
cmake_policy(SET CMP0022 OLD) # interface link libraries
cmake_policy(SET CMP0042 OLD) # osx rpath
endif()

If curl fails to compile, in src/CMakeLists.txt, add rtmp to target_link_libraries where libcurl.a is.
target_link_libraries(avitab_common
${PROJECT_SOURCE_DIR}/build-third/lib/libgeotiff.a
${PROJECT_SOURCE_DIR}/build-third/lib/libproj.a
${PROJECT_SOURCE_DIR}/build-third/lib/libtiff.a
${PROJECT_SOURCE_DIR}/build-third/lib/libxtiff.a
${PROJECT_SOURCE_DIR}/build-third/lib/libmupdf.a
${PROJECT_SOURCE_DIR}/build-third/lib/libmupdf-third.a
${PROJECT_SOURCE_DIR}/build-third/lib/libcurl.a
${PROJECT_SOURCE_DIR}/build-third/lib/libmbedtls.a
${PROJECT_SOURCE_DIR}/build-third/lib/libmbedx509.a
${PROJECT_SOURCE_DIR}/build-third/lib/libmbedcrypto.a
${PROJECT_SOURCE_DIR}/build-third/lib/libdetex.a
${PROJECT_SOURCE_DIR}/build-third/lib/libquickjs.a
world
navsql
sqlite3
rtmp # Add this
)

Download latest version of mupdf, currently 1.26.11 (https://mupdf.com/releases?product=MuPDF), or try to clone it from the master repo at github.
Replace the folder lib/mupdf with this new version.

Somehow, the version change of mupdf is affecting libgeotiff in the build. Hence libgeotiff fails to compile because it cannot find
a function in the libtiff library. The fix is to manually edit the build_dependecies.sh.
Change line 122 (at the section where libgeotiff is built) to:
cmake -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX=$OUTDIR -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_FLAGS=-fPIC -DTIFF_LIBRARY=$OUTDIR/lib/libtiff.a -DTIFF_LIBRARIES=$OUTDIR/lib/libtiff.a -DTIFF_INCLUDE_DIR=$OUTDIR/include ..

Also, as some extra cream on the cake, libgeotiff fails to compile against the 'proj' library, so a new version of proj is needed aswell.
Version 9.70 works, which is currently the latest (https://github.com/OSGeo/PROJ/releases).
Change line 108 (at the section where proj is built) to:
cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE=Release -DPROJ_TESTS=OFF -DBUILD_SHARED_LIBS=OFF -DCMAKE_C_FLAGS=-fPIC -DCMAKE_INSTALL_PREFIX=$OUTDIR ..

Compiling the dependecies.
$ export CMAKE_POLICY_VERSION_MINIMUM=3.5
$ ./build_dependencies.sh
(if you compiled and failed before, it is important to run clean_dependencies.sh)

If successfully compiled, compile AviTab plugin:
$ mkdir build
$ cd build
$ cmake .. -G "Unix Makefiles" -DCMAKE_CXX_FLAGS="-include cstdint"
$ make

The file is now much bigger than the original (about 60 Mb). I guess it maybe compiled for debugging.

[JT8D-17]

Can you please upload the compiled plugin somewhere?

MuPDF's master branch refuses to build for me with this error

error: passing argument 4 of ‘jbig2_ctx_new_imp’ from incompatible pointer type [-Wincompatible-pointer-types]

which needs to be fixed with "XCFLAGS=-fPIC\ -fpermissive " in line 63 of build_dependencies.sh.

But then the build fails with
source/fitz/output-docx.c:28:10: fatal error: extract/extract.h: No such file or directory 28 | #include "extract/extract.h"

Sigh. I don't have the time to fix this dependency hell...

[Vantskruv]

@JT8D-17 Temporarly uploading it.
https://drive.google.com/file/d/1OeveMloa7640Orrm-Pc7qk0PMvSdQxtJ/view?usp=sharing
Notify me after you downloaded it, and then I will remove it.
Edit: Navigraph will not work though, only loading PDF files.

[JT8D-17]

Thanks; got it!
Unfortunately, your build does not launch at all for me (on Arch Linux). And neither Log.txt nor the terminal nor ldd can tell me what's wrong or missing. :/

[Vantskruv]

That is frustrating that you cannot get it to run, or even compile it, and you are running an arch distribution, as I am (EndeavourOS in my case).

A stupid question but do you keep the same files and folder structure as AviTab come released and you are replacing the AviTab.xpl in AviTab/lin_x64 path (if remember it correctly, AviTab needs to have some configuration files available when running)?

Also, have you tried compile MuPDF against version 1.26.11 instead? The master repo is changing constantly, so it is not reliable (I did compile against 1.26.11).
Downloading released sources should include all its dependencies.
https://mupdf.com/releases?product=MuPDF

This is what my output of 'ldd' looks like both for the original, and the one I compiled myself.
`
Original plugin:
linux-vdso.so.1 (0x0000792394aba000)
libGL.so.1 => /usr/lib/libGL.so.1 (0x0000792393b45000)
libm.so.6 => /usr/lib/libm.so.6 (0x0000792393a37000)
libmvec.so.1 => /usr/lib/libmvec.so.1 (0x0000792393936000)
libc.so.6 => /usr/lib/libc.so.6 (0x0000792393600000)
/usr/lib64/ld-linux-x86-64.so.2 (0x0000792394abc000)
libGLdispatch.so.0 => /usr/lib/libGLdispatch.so.0 (0x00007923938bd000)
libGLX.so.0 => /usr/lib/libGLX.so.0 (0x000079239388c000)
libX11.so.6 => /usr/lib/libX11.so.6 (0x00007923934bf000)
libxcb.so.1 => /usr/lib/libxcb.so.1 (0x0000792393861000)
libXau.so.6 => /usr/lib/libXau.so.6 (0x0000792394aad000)
libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x0000792394aa5000)

And for the compiled one:
linux-vdso.so.1 (0x00007367d1ad5000)
libGL.so.1 => /usr/lib/libGL.so.1 (0x00007367ce345000)
librtmp.so.1 => /usr/lib/librtmp.so.1 (0x00007367ce327000)
libm.so.6 => /usr/lib/libm.so.6 (0x00007367ce219000)
libmvec.so.1 => /usr/lib/libmvec.so.1 (0x00007367ce118000)
libc.so.6 => /usr/lib/libc.so.6 (0x00007367cde00000)
/usr/lib64/ld-linux-x86-64.so.2 (0x00007367d1ad7000)
libGLdispatch.so.0 => /usr/lib/libGLdispatch.so.0 (0x00007367ce09f000)
libGLX.so.0 => /usr/lib/libGLX.so.0 (0x00007367ce06e000)
libgnutls.so.30 => /usr/lib/libgnutls.so.30 (0x00007367cda00000)
libhogweed.so.6 => /usr/lib/libhogweed.so.6 (0x00007367ce023000)
libnettle.so.8 => /usr/lib/libnettle.so.8 (0x00007367cdda6000)
libgmp.so.10 => /usr/lib/libgmp.so.10 (0x00007367cdd00000)
libz.so.1 => /usr/lib/libz.so.1 (0x00007367cdce7000)
libX11.so.6 => /usr/lib/libX11.so.6 (0x00007367cd8bf000)
libleancrypto.so.1 => /usr/lib/libleancrypto.so.1 (0x00007367cd600000)
libp11-kit.so.0 => /usr/lib/libp11-kit.so.0 (0x00007367cd49a000)
libidn2.so.0 => /usr/lib/libidn2.so.0 (0x00007367cdcc5000)
libunistring.so.5 => /usr/lib/libunistring.so.5 (0x00007367cd2b7000)
libtasn1.so.6 => /usr/lib/libtasn1.so.6 (0x00007367cdcaf000)
libxcb.so.1 => /usr/lib/libxcb.so.1 (0x00007367cdc84000)
libffi.so.8 => /usr/lib/libffi.so.8 (0x00007367d1abd000)
libXau.so.6 => /usr/lib/libXau.so.6 (0x00007367ce01e000)
libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x00007367ce016000)`

So there are more dependencies with the the compiled version.
Maybe there are some dependencies that are missing in your system. You did run ldd however so that is probably not the cause that it not runs.

I hope @fpw can replace mupdf with a more lightweight library instead, the first the come up in my mind is:
https://github.com/libharu/libharu

[JT8D-17]

Of course the file structure of the plugin is retained. I merely replace the xpl.

The first attempt was working "natively" with the submodules by updating them to their respective master branch. When that did not work, I tried your method with replacing the entire folder, but that also only produces a compilation error.
Switching the submodule branch to 1.26.11 fails the compilation with the same error as with the master branch.

But your XPL works now. Turns out I was missing librtmp (supplied by Arch's rtmpdump package). How that slipped by during yesterday's ldd inspection is a mystery.
Anyway, thanks for compiling it.

WTF, building mupdf from the downloaded and unzipped source code with the exact commmands as in "build_dependencies.sh" works just fine.