Conflicting definitions of struct stat

[th-otto]

In sources/open.c, struct stat is included from <sys/stat.h>, which is not provided here and therefor taken from mintlib. But the implementation of stat() uses the structure definition of include/ext.h, which is the Pure-C one.

I just wonder whether that can work at all?

[th-otto]

Bump. This simply cannot work. I suggest to remove struct stat from ext.h (or better, remove ext.h completely, since that is from Pure-C only), and provide a mintlib compatible sys/stat.h instead.

See also https://www.atari-forum.com/viewtopic.php?p=482542#p482542: libcmini currently does not even compile, if you don't have mintlib also installed somewhere.

#128 might also be related to this.

[czietz]

I just discovered this issue independently while building a 3rd-party program, which uses #include <sys/stat.h> (the POSIX header file for stat()). As already described here, the program therefore took the definitions (in particular of struct stat) from FreeMiNT, where as libcmini used its incompatible definitions from ext.h:

libcmini/sources/stat.c

Line 4 in 42a73ab

#include <ext.h>

Hence, stat() would not work correctly.

You have my vote for cleaning this up.