From 1b42facee8d5380d6fb584009f4e55a44b8c3801 Mon Sep 17 00:00:00 2001 From: Aleksej Frank Date: Tue, 17 Sep 2019 20:02:22 +0200 Subject: [PATCH 1/3] fix: fixes wifi connection implementation on windows #89 --- src/windows-connect.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/windows-connect.js b/src/windows-connect.js index f31d6a9..840423e 100644 --- a/src/windows-connect.js +++ b/src/windows-connect.js @@ -44,7 +44,7 @@ function connectToWifi(config, ap, callback) { ]); }) .then(function() { - var cmd = 'cmd'; + var cmd = 'netsh'; var params = [ 'wlan', 'connect', From 391d48a2422728860c56c5176cc5b8c69dd96606 Mon Sep 17 00:00:00 2001 From: Aleksej Frank Date: Fri, 20 Sep 2019 20:32:33 +0200 Subject: [PATCH 2/3] fix: fixing the deletion of nodeWifiConnect.xml --- src/windows-connect.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/windows-connect.js b/src/windows-connect.js index 840423e..a0a3c96 100644 --- a/src/windows-connect.js +++ b/src/windows-connect.js @@ -57,7 +57,15 @@ function connectToWifi(config, ap, callback) { return execCommand(cmd, params); }) .then(function() { - return execCommand('del ".\\nodeWifiConnect.xml"'); + return new Promise(function(resolve, reject) { + fs.unlink("nodeWifiConnect.xml", function(err) { + if (err) { + reject(err); + } else { + resolve(""); + } + }); + }); }) .then(function() { callback && callback(); From bbca751f51b26b21f3eaed75303f3ff03fd6c39c Mon Sep 17 00:00:00 2001 From: Aleksej Frank Date: Fri, 20 Sep 2019 20:44:38 +0200 Subject: [PATCH 3/3] fix: fixed code style with prettier --- src/windows-connect.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/windows-connect.js b/src/windows-connect.js index a0a3c96..086b574 100644 --- a/src/windows-connect.js +++ b/src/windows-connect.js @@ -58,11 +58,11 @@ function connectToWifi(config, ap, callback) { }) .then(function() { return new Promise(function(resolve, reject) { - fs.unlink("nodeWifiConnect.xml", function(err) { + fs.unlink('nodeWifiConnect.xml', function(err) { if (err) { reject(err); } else { - resolve(""); + resolve(''); } }); });