Add Middle Click (Hold) mode and UI enhancements#10
Open
hadarshamir wants to merge 2 commits intofromis-9:mainfrom
Open
Add Middle Click (Hold) mode and UI enhancements#10hadarshamir wants to merge 2 commits intofromis-9:mainfrom
hadarshamir wants to merge 2 commits intofromis-9:mainfrom
Conversation
hadarshamir
force-pushed
the
feature/enhancements-proper
branch
4 times, most recently
from
afaa420 to
0737f75
Compare
## New Features - **Middle Click (Hold)**: New activation method that stops scrolling when you release the middle mouse button - **Scroll Speed Menu**: Replaced slider with dropdown menu offering 6 preset speeds (0.5x to 3.0x) - **Faster Scrolling**: Increased maximum scroll speed from 30px to 60px and acceleration from 2.5x to 4.0x - **Hide from Dock**: App now only appears in menu bar (using NSApp.setActivationPolicy(.accessory) and LSUIElement) - **Trackpad Activation Toggle**: Added menu option to enable/disable Option+Scroll trackpad activation ## Improvements - Removed unused 'Activation Methods' info menu - Fixed trackpad mode to stop on any mouse click (not just middle click) - Ensured click monitor is active for trackpad/manual activation modes - Updated About dialog with clearer activation method descriptions ## Bug Fixes - **Added missing project.pbxproj file** (closes fromis-9#8) - Project can now be built from source ## Technical Details - Added middleClickHold enum case with usesHoldBehavior property - Split click monitor setup into separate function for dynamic behavior switching - Monitor is properly recreated when changing activation methods - Trackpad toggle persists via UserDefaults (defaults to enabled) All changes maintain backward compatibility with existing functionality.
hadarshamir
force-pushed
the
feature/enhancements-proper
branch
from
0737f75 to
0dd143e
Compare
setupClickMonitor() was only called when manually selecting an activation method, causing hold-behavior modes like "Middle Click (Hold)" to not work after app restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds several enhancements to Scrollapp:
New Features
Improvements
Bug Fixes
Technical Details
middleClickHoldenum case withusesHoldBehaviorpropertyNSApp.setActivationPolicy(.accessory)andLSUIElementin Info.plist to hide from DockAll changes maintain backward compatibility with existing functionality.