From b6b011ed09686fe36618a66a88355dc5edadb432 Mon Sep 17 00:00:00 2001 From: Ricardo Leal Date: Mon, 19 Jan 2026 22:31:22 +0000 Subject: [PATCH] fix(ansible/tasks): update ansible_facts syntax for compatibility - change ansible_facts usage from dot notation to bracket notation - ensure compatibility with newer Ansible versions --- README.md | 6 +++--- molecule/default/converge.yml | 2 +- tasks/main.yml | 28 ++++++++++++++-------------- tasks/setup-Debian.yml | 6 +++--- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/README.md b/README.md index 85f4ea43..0b89ac43 100644 --- a/README.md +++ b/README.md @@ -40,7 +40,7 @@ For RHEL / CentOS: - hosts: server roles: - role: geerlingguy.java - when: "ansible_facts.os_family == 'RedHat'" + when: "ansible_facts['os_family'] == 'RedHat'" java_packages: - java-1.8.0-openjdk @@ -50,11 +50,11 @@ For Ubuntu < 16.04: tasks: - name: installing repo for Java 8 in Ubuntu apt_repository: repo='ppa:openjdk-r/ppa' - + - hosts: server roles: - role: geerlingguy.java - when: "ansible_facts.os_family == 'Debian'" + when: "ansible_facts['os_family'] == 'Debian'" java_packages: - openjdk-8-jdk diff --git a/molecule/default/converge.yml b/molecule/default/converge.yml index 14168300..57088fee 100644 --- a/molecule/default/converge.yml +++ b/molecule/default/converge.yml @@ -8,7 +8,7 @@ apt: update_cache: true cache_valid_time: 600 - when: ansible_facts.os_family == 'Debian' + when: ansible_facts['os_family'] == 'Debian' changed_when: false roles: diff --git a/tasks/main.yml b/tasks/main.yml index c596b74a..b7f3e2fb 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -1,16 +1,16 @@ --- - name: Include OS-specific variables for Fedora or FreeBSD. - include_vars: "{{ ansible_facts.distribution }}.yml" - when: ansible_facts.distribution == 'FreeBSD' or ansible_facts.distribution == 'Fedora' + include_vars: "{{ ansible_facts['distribution'] }}.yml" + when: ansible_facts['distribution'] == 'FreeBSD' or ansible_facts['distribution'] == 'Fedora' - name: Include OS-specific variables for Amazon. - include_vars: "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_version}}.yml" - when: ansible_facts.distribution == 'Amazon' + include_vars: "{{ ansible_facts['distribution'] }}-{{ ansible_facts['distribution_version']}}.yml" + when: ansible_facts['distribution'] == 'Amazon' - name: Include version-specific variables for CentOS/RHEL. - include_vars: "RedHat-{{ ansible_facts.distribution_version.split('.')[0] }}.yml" + include_vars: "RedHat-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" when: >- - ansible_facts.distribution in [ + ansible_facts['distribution'] in [ 'CentOS', 'Red Hat Enterprise Linux', 'RedHat', @@ -20,12 +20,12 @@ ] - name: Include version-specific variables for Ubuntu. - include_vars: "{{ ansible_facts.distribution }}-{{ ansible_facts.distribution_version.split('.')[0] }}.yml" - when: ansible_facts.distribution == 'Ubuntu' + include_vars: "{{ ansible_facts['distribution'] }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + when: ansible_facts['distribution'] == 'Ubuntu' - name: Include version-specific variables for Debian. - include_vars: "{{ ansible_facts.distribution | title }}-{{ ansible_facts.distribution_version.split('.')[0] }}.yml" - when: ansible_facts.os_family == 'Debian' + include_vars: "{{ ansible_facts['distribution'] | title }}-{{ ansible_facts['distribution_version'].split('.')[0] }}.yml" + when: ansible_facts['os_family'] == 'Debian' - name: Define java_packages. set_fact: @@ -34,16 +34,16 @@ # Setup/install tasks. - include_tasks: setup-RedHat.yml - when: ansible_facts.os_family == 'RedHat' + when: ansible_facts['os_family'] == 'RedHat' - include_tasks: setup-Amazon.yml - when: ansible_facts.distribution == 'Amazon' + when: ansible_facts['distribution'] == 'Amazon' - include_tasks: setup-Debian.yml - when: ansible_facts.os_family == 'Debian' + when: ansible_facts['os_family'] == 'Debian' - include_tasks: setup-FreeBSD.yml - when: ansible_facts.os_family == 'FreeBSD' + when: ansible_facts['os_family'] == 'FreeBSD' # Environment setup. - name: Set JAVA_HOME if configured. diff --git a/tasks/setup-Debian.yml b/tasks/setup-Debian.yml index 3708d7dc..199ba5b6 100644 --- a/tasks/setup-Debian.yml +++ b/tasks/setup-Debian.yml @@ -2,13 +2,13 @@ # See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199 and # https://github.com/geerlingguy/ansible-role-java/issues/64 - name: Ensure 'man' directory exists. - file: # noqa 208 + file: # noqa 208 path: /usr/share/man/man1 state: directory mode: 0755 when: - - ansible_facts.distribution == 'Ubuntu' - - ansible_facts.distribution_major_version | int >= 18 + - ansible_facts['distribution'] == 'Ubuntu' + - ansible_facts['distribution_major_version'] | int >= 18 - name: Ensure Java is installed. apt: