Skip to content
This repository was archived by the owner on Nov 6, 2022. It is now read-only.
This repository was archived by the owner on Nov 6, 2022. It is now read-only.

No warning on saving new block if mismatched types #490

@webstationhq

Description

@webstationhq

I recently used the free version of block lab and found a bug/possible enhancement (you decide - I can write patch if needed).

To reproduce:

  1. Add a new block (name it whatever)
  2. Add a new field. Make the field type "email"
  3. On the default value, make it "foo"
  4. Close the field using the "Close Field" button
  5. OPTIONAL: Add other fields. I added 12 before I tried to publish.
  6. Try to publish the new block.

There is no visible warning. If you try to publish prior to step 4, you will see a warning that pops up using bootstrap validation on the default value field. Once the field is closed, there was no visible warning.

Browser: Chrome/OSX

Why: We often add many fields and change many field values prior to saving. since you can only have one field inspector open at a time, if the error occurs in a closed field, there is no warning. This causes a bit of confusion.

Resolution: Global warning? Switch validation to occur on the field close event and cancel the close until the problem is rectified?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions