Bug fix - out of order sn/dt pairs, and sense dividers feature.#3
Open
Pugio wants to merge 3 commits intogniquil:masterfrom
Open
Bug fix - out of order sn/dt pairs, and sense dividers feature.#3Pugio wants to merge 3 commits intogniquil:masterfrom
Pugio wants to merge 3 commits intogniquil:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent dummy_nodes addition in entry_parser.rb:46 only triggered in the case of non-even node count, but the error it was designed to correct could also occur in the case of an even number of (sn+dt) nodes (ie. in a case where several 'sn's have multiple dt nodes).
The above case (an 'sn' node with multiple 'dt' nodes) also highlights the utility of adding sense descriptors to distinguish between two adjacent definition text (dt) nodes.