Skip to content

Commit 99a06fc

Browse files
l46kokcopybara-github
authored andcommitted
Migrate CelBaselineTestCase away from proto based types
PiperOrigin-RevId: 785592206
1 parent 7fe805c commit 99a06fc

18 files changed

+372
-724
lines changed

checker/src/test/java/dev/cel/checker/ExprCheckerTest.java

Lines changed: 146 additions & 177 deletions
Large diffs are not rendered by default.
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
Source: size(x) == x.size()
2-
declare size {
3-
function my_size list(A).() -> int
4-
}
52
declare x {
63
value list(int)
74
}
5+
declare size {
6+
function my_size list(A).() -> int
7+
}
88
=====>
99
_==_(
1010
size(
1111
x~list(int)^x
1212
)~int^size_list,
1313
x~list(int)^x.size()~int^my_size
14-
)~bool^equals
14+
)~bool^equals

checker/src/test/resources/standardEnvDump.baseline

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,15 @@ declare _||_ {
143143
}
144144
declare bool {
145145
value type(bool)
146+
}
147+
declare bool {
146148
function bool_to_bool (bool) -> bool
147149
function string_to_bool (string) -> bool
148150
}
149151
declare bytes {
150152
value type(bytes)
153+
}
154+
declare bytes {
151155
function bytes_to_bytes (bytes) -> bytes
152156
function string_to_bytes (string) -> bytes
153157
}
@@ -156,6 +160,8 @@ declare contains {
156160
}
157161
declare double {
158162
value type(double)
163+
}
164+
declare double {
159165
function double_to_double (double) -> double
160166
function int64_to_double (int) -> double
161167
function uint64_to_double (uint) -> double
@@ -167,6 +173,8 @@ declare duration {
167173
}
168174
declare dyn {
169175
value type(dyn)
176+
}
177+
declare dyn {
170178
function to_dyn (A) -> dyn
171179
}
172180
declare endsWith {
@@ -218,6 +226,8 @@ declare getSeconds {
218226
}
219227
declare int {
220228
value type(int)
229+
}
230+
declare int {
221231
function int64_to_int64 (int) -> int
222232
function uint64_to_int64 (uint) -> int
223233
function double_to_int64 (double) -> int
@@ -252,6 +262,8 @@ declare startsWith {
252262
}
253263
declare string {
254264
value type(string)
265+
}
266+
declare string {
255267
function string_to_string (string) -> string
256268
function int64_to_string (int) -> string
257269
function uint64_to_string (uint) -> string
@@ -268,12 +280,16 @@ declare timestamp {
268280
}
269281
declare type {
270282
value type(dyn)
283+
}
284+
declare type {
271285
function type (A) -> type(A)
272286
}
273287
declare uint {
274288
value type(uint)
289+
}
290+
declare uint {
275291
function uint64_to_uint64 (uint) -> uint
276292
function int64_to_uint64 (int) -> uint
277293
function double_to_uint64 (double) -> uint
278294
function string_to_uint64 (string) -> uint
279-
}
295+
}
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
Source: size(x) == 1u
2-
declare size {
3-
function my_size (list(TEST)) -> uint
4-
}
52
declare x {
63
value list(int)
74
}
5+
declare size {
6+
function my_size (list(TEST)) -> uint
7+
}
88
=====>
99
_==_(
1010
size(
1111
x~list(int)^x
1212
)~uint^my_size,
1313
1u~uint
14-
)~bool^equals
15-
14+
)~bool^equals

runtime/src/test/java/dev/cel/runtime/CelLiteInterpreterTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
package dev.cel.runtime;
1616

17-
import com.google.testing.junit.testparameterinjector.TestParameter;
1817
import com.google.testing.junit.testparameterinjector.TestParameterInjector;
1918
import dev.cel.common.values.ProtoMessageLiteValueProvider;
2019
import dev.cel.expr.conformance.proto3.TestAllTypesCelDescriptor;
@@ -28,16 +27,14 @@
2827
*/
2928
@RunWith(TestParameterInjector.class)
3029
public class CelLiteInterpreterTest extends BaseInterpreterTest {
31-
public CelLiteInterpreterTest(@TestParameter InterpreterTestOption testOption) {
30+
public CelLiteInterpreterTest() {
3231
super(
33-
testOption.celOptions.toBuilder().enableCelValue(true).build(),
34-
testOption.useNativeCelType,
3532
CelRuntimeFactory.standardCelRuntimeBuilder()
3633
.setValueProvider(
3734
ProtoMessageLiteValueProvider.newInstance(
3835
TestAllTypesCelDescriptor.getDescriptor()))
3936
.addLibraries(CelOptionalLibrary.INSTANCE)
40-
.setOptions(testOption.celOptions.toBuilder().enableCelValue(true).build())
37+
.setOptions(newBaseCelOptions().toBuilder().enableCelValue(true).build())
4138
.build());
4239
}
4340

runtime/src/test/java/dev/cel/runtime/CelValueInterpreterTest.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
package dev.cel.runtime;
1616

17-
import com.google.testing.junit.testparameterinjector.TestParameter;
1817
import com.google.testing.junit.testparameterinjector.TestParameterInjector;
1918
// import com.google.testing.testsize.MediumTest;
2019
import dev.cel.testing.BaseInterpreterTest;
@@ -25,9 +24,7 @@
2524
@RunWith(TestParameterInjector.class)
2625
public class CelValueInterpreterTest extends BaseInterpreterTest {
2726

28-
public CelValueInterpreterTest(@TestParameter InterpreterTestOption testOption) {
29-
super(
30-
testOption.celOptions.toBuilder().enableCelValue(true).build(),
31-
testOption.useNativeCelType);
27+
public CelValueInterpreterTest() {
28+
super(newBaseCelOptions().toBuilder().enableCelValue(true).build());
3229
}
3330
}

runtime/src/test/java/dev/cel/runtime/InterpreterTest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
package dev.cel.runtime;
1616

17-
import com.google.testing.junit.testparameterinjector.TestParameter;
1817
import com.google.testing.junit.testparameterinjector.TestParameterInjector;
1918
// import com.google.testing.testsize.MediumTest;
2019
import dev.cel.testing.BaseInterpreterTest;
@@ -23,9 +22,4 @@
2322
/** Tests for {@link Interpreter} and related functionality. */
2423
// @MediumTest
2524
@RunWith(TestParameterInjector.class)
26-
public class InterpreterTest extends BaseInterpreterTest {
27-
28-
public InterpreterTest(@TestParameter InterpreterTestOption testOption) {
29-
super(testOption.celOptions, testOption.useNativeCelType);
30-
}
31-
}
25+
public class InterpreterTest extends BaseInterpreterTest {}

runtime/src/test/resources/delayedEvaluation.baseline

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,29 +10,29 @@ bindings: {}
1010
result: true
1111

1212
Source: f_force(f_delay(1 + four)) == 5
13+
declare four {
14+
value int
15+
}
1316
declare f_delay {
1417
function f_delay (int) -> dyn
1518
}
1619
declare f_force {
1720
function f_force (dyn) -> int
1821
}
19-
declare four {
20-
value int
21-
}
2222
=====>
2323
bindings: {four=4}
2424
result: true
2525

2626
Source: [1, 2, 3].map(i, f_delay(i + four)).map(d, f_force(d)) == [5, 6, 7]
27+
declare four {
28+
value int
29+
}
2730
declare f_delay {
2831
function f_delay (int) -> dyn
2932
}
3033
declare f_force {
3134
function f_force (dyn) -> int
3235
}
33-
declare four {
34-
value int
35-
}
3636
=====>
3737
bindings: {four=4}
3838
result: true

runtime/src/test/resources/longComprehension.baseline

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,23 +7,23 @@ bindings: {}
77
result: true
88

99
Source: size(longlist.map(x, x+1)) == 1000
10-
declare constantLongList {
11-
function constantLongList () -> list(int)
12-
}
1310
declare longlist {
1411
value list(int)
1512
}
13+
declare constantLongList {
14+
function constantLongList () -> list(int)
15+
}
1616
=====>
1717
bindings: {longlist=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 256, 257, 258, 259, 260, 261, 262, 263, 264, 265, 266, 267, 268, 269, 270, 271, 272, 273, 274, 275, 276, 277, 278, 279, 280, 281, 282, 283, 284, 285, 286, 287, 288, 289, 290, 291, 292, 293, 294, 295, 296, 297, 298, 299, 300, 301, 302, 303, 304, 305, 306, 307, 308, 309, 310, 311, 312, 313, 314, 315, 316, 317, 318, 319, 320, 321, 322, 323, 324, 325, 326, 327, 328, 329, 330, 331, 332, 333, 334, 335, 336, 337, 338, 339, 340, 341, 342, 343, 344, 345, 346, 347, 348, 349, 350, 351, 352, 353, 354, 355, 356, 357, 358, 359, 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, 370, 371, 372, 373, 374, 375, 376, 377, 378, 379, 380, 381, 382, 383, 384, 385, 386, 387, 388, 389, 390, 391, 392, 393, 394, 395, 396, 397, 398, 399, 400, 401, 402, 403, 404, 405, 406, 407, 408, 409, 410, 411, 412, 413, 414, 415, 416, 417, 418, 419, 420, 421, 422, 423, 424, 425, 426, 427, 428, 429, 430, 431, 432, 433, 434, 435, 436, 437, 438, 439, 440, 441, 442, 443, 444, 445, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455, 456, 457, 458, 459, 460, 461, 462, 463, 464, 465, 466, 467, 468, 469, 470, 471, 472, 473, 474, 475, 476, 477, 478, 479, 480, 481, 482, 483, 484, 485, 486, 487, 488, 489, 490, 491, 492, 493, 494, 495, 496, 497, 498, 499, 500, 501, 502, 503, 504, 505, 506, 507, 508, 509, 510, 511, 512, 513, 514, 515, 516, 517, 518, 519, 520, 521, 522, 523, 524, 525, 526, 527, 528, 529, 530, 531, 532, 533, 534, 535, 536, 537, 538, 539, 540, 541, 542, 543, 544, 545, 546, 547, 548, 549, 550, 551, 552, 553, 554, 555, 556, 557, 558, 559, 560, 561, 562, 563, 564, 565, 566, 567, 568, 569, 570, 571, 572, 573, 574, 575, 576, 577, 578, 579, 580, 581, 582, 583, 584, 585, 586, 587, 588, 589, 590, 591, 592, 593, 594, 595, 596, 597, 598, 599, 600, 601, 602, 603, 604, 605, 606, 607, 608, 609, 610, 611, 612, 613, 614, 615, 616, 617, 618, 619, 620, 621, 622, 623, 624, 625, 626, 627, 628, 629, 630, 631, 632, 633, 634, 635, 636, 637, 638, 639, 640, 641, 642, 643, 644, 645, 646, 647, 648, 649, 650, 651, 652, 653, 654, 655, 656, 657, 658, 659, 660, 661, 662, 663, 664, 665, 666, 667, 668, 669, 670, 671, 672, 673, 674, 675, 676, 677, 678, 679, 680, 681, 682, 683, 684, 685, 686, 687, 688, 689, 690, 691, 692, 693, 694, 695, 696, 697, 698, 699, 700, 701, 702, 703, 704, 705, 706, 707, 708, 709, 710, 711, 712, 713, 714, 715, 716, 717, 718, 719, 720, 721, 722, 723, 724, 725, 726, 727, 728, 729, 730, 731, 732, 733, 734, 735, 736, 737, 738, 739, 740, 741, 742, 743, 744, 745, 746, 747, 748, 749, 750, 751, 752, 753, 754, 755, 756, 757, 758, 759, 760, 761, 762, 763, 764, 765, 766, 767, 768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782, 783, 784, 785, 786, 787, 788, 789, 790, 791, 792, 793, 794, 795, 796, 797, 798, 799, 800, 801, 802, 803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817, 818, 819, 820, 821, 822, 823, 824, 825, 826, 827, 828, 829, 830, 831, 832, 833, 834, 835, 836, 837, 838, 839, 840, 841, 842, 843, 844, 845, 846, 847, 848, 849, 850, 851, 852, 853, 854, 855, 856, 857, 858, 859, 860, 861, 862, 863, 864, 865, 866, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 880, 881, 882, 883, 884, 885, 886, 887, 888, 889, 890, 891, 892, 893, 894, 895, 896, 897, 898, 899, 900, 901, 902, 903, 904, 905, 906, 907, 908, 909, 910, 911, 912, 913, 914, 915, 916, 917, 918, 919, 920, 921, 922, 923, 924, 925, 926, 927, 928, 929, 930, 931, 932, 933, 934, 935, 936, 937, 938, 939, 940, 941, 942, 943, 944, 945, 946, 947, 948, 949, 950, 951, 952, 953, 954, 955, 956, 957, 958, 959, 960, 961, 962, 963, 964, 965, 966, 967, 968, 969, 970, 971, 972, 973, 974, 975, 976, 977, 978, 979, 980, 981, 982, 983, 984, 985, 986, 987, 988, 989, 990, 991, 992, 993, 994, 995, 996, 997, 998, 999]}
1818
result: true
1919

2020
Source: f_unleash(longlist.map(x, f_slow_inc(x)))[0] == 1
21-
declare constantLongList {
22-
function constantLongList () -> list(int)
23-
}
2421
declare longlist {
2522
value list(int)
2623
}
24+
declare constantLongList {
25+
function constantLongList () -> list(int)
26+
}
2727
declare f_slow_inc {
2828
function f_slow_inc (int) -> int
2929
}

testing/BUILD.bazel

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,6 @@ java_library(
2121
exports = ["//testing/src/main/java/dev/cel/testing:baseline_test_case"],
2222
)
2323

24-
java_library(
25-
name = "test_decls",
26-
exports = ["//testing/src/main/java/dev/cel/testing:test_decls"],
27-
)
28-
2924
java_library(
3025
name = "cel_baseline_test_case",
3126
exports = ["//testing/src/main/java/dev/cel/testing:cel_baseline_test_case"],

0 commit comments

Comments
 (0)