From 549fb9549356e14219dbc398b733ffeb5dcab07c Mon Sep 17 00:00:00 2001 From: Splice Team Date: Tue, 10 Mar 2026 15:51:18 -0700 Subject: [PATCH] Enhance SpliceD logging for domain join failures PiperOrigin-RevId: 881659566 --- shared/provisioning/provisioning_windows.go | 4 ++-- spliced/spliced.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/shared/provisioning/provisioning_windows.go b/shared/provisioning/provisioning_windows.go index e67b3b7..cc14d6b 100644 --- a/shared/provisioning/provisioning_windows.go +++ b/shared/provisioning/provisioning_windows.go @@ -149,7 +149,7 @@ func TextData(hostname, domain string, reuse, djoinCompat bool) ([]byte, error) uintptr(unsafe.Pointer(&buff)), //_Out_opt_ LPWSTR *pProvisionTextData ) if r != 0 { - return result, errnoErr(syscall.Errno(r)) + return result, fmt.Errorf("%v: Win32 error %d", errnoErr(syscall.Errno(r)), r) } for i := range buff { @@ -192,7 +192,7 @@ func BinData(hostname string, domain string, reuse bool) ([]byte, error) { 0, //_Out_opt_ LPWSTR *pProvisionTextData ) if r != 0 { - return buff[:binSize], errnoErr(syscall.Errno(r)) + return buff[:binSize], fmt.Errorf("%v: Win32 error %d", errnoErr(syscall.Errno(r)), r) } return buff[:binSize], nil diff --git a/spliced/spliced.go b/spliced/spliced.go index 4e76453..29cb012 100644 --- a/spliced/spliced.go +++ b/spliced/spliced.go @@ -198,7 +198,7 @@ func join(req *models.Request) ([]byte, error) { metrics.Get("join_attempt").Increment() blob, err := provisioner(wantName, conf.Domain, permitReuse(req)) if err != nil { - deck.WarningfA("Failed to join host with: %v", err).With(eventID(EvtJoinFailure)).Go() + deck.WarningfA("Failed to join host %s to domain %s (reuse=%t) with: %v", wantName, conf.Domain, permitReuse(req), err).With(eventID(EvtJoinFailure)).Go() return nil, err }