From d5d52dc18c6a828d1032d159c48f317d277dbcdb Mon Sep 17 00:00:00 2001 From: spaenleh Date: Wed, 25 Feb 2026 09:26:59 +0100 Subject: [PATCH 1/5] fix: use node:path instead of path --- cypress/e2e/builder/item/download/downloadItem.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/e2e/builder/item/download/downloadItem.cy.ts b/cypress/e2e/builder/item/download/downloadItem.cy.ts index 4774b4f82..c8a7ad4a2 100644 --- a/cypress/e2e/builder/item/download/downloadItem.cy.ts +++ b/cypress/e2e/builder/item/download/downloadItem.cy.ts @@ -6,7 +6,7 @@ import { PackedFolderItemFactory, } from '@graasp/sdk'; -import path from 'path'; +import path from 'node:path'; import { buildDataCyWrapper, From f6009aba6a2482ebc7f7839fdf4fe4d932f96b42 Mon Sep 17 00:00:00 2001 From: spaenleh Date: Wed, 25 Feb 2026 09:29:15 +0100 Subject: [PATCH 2/5] fix: default object value --- cypress/e2e/builder/item/publish/ccLicense.cy.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cypress/e2e/builder/item/publish/ccLicense.cy.ts b/cypress/e2e/builder/item/publish/ccLicense.cy.ts index dc2475181..6f353b0db 100644 --- a/cypress/e2e/builder/item/publish/ccLicense.cy.ts +++ b/cypress/e2e/builder/item/publish/ccLicense.cy.ts @@ -136,9 +136,9 @@ const setUpAndVisitItemPage = (item: ItemForTest) => { openPublishItemTab(item.id); }; -const openLicenseModal = ( - { hasALicense }: { hasALicense: boolean } = { hasALicense: true }, -) => +const openLicenseModal = ({ + hasALicense = true, +}: { hasALicense?: boolean } = {}) => cy .get( buildDataCyWrapper( From d020fb751e8eaad062f2a5ff474bb0654d280b0c Mon Sep 17 00:00:00 2001 From: spaenleh Date: Wed, 25 Feb 2026 09:31:11 +0100 Subject: [PATCH 3/5] fix: do not use default object value --- cypress/e2e/builder/item/publish/publishedItem.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/e2e/builder/item/publish/publishedItem.cy.ts b/cypress/e2e/builder/item/publish/publishedItem.cy.ts index 009a5816b..9769b6789 100644 --- a/cypress/e2e/builder/item/publish/publishedItem.cy.ts +++ b/cypress/e2e/builder/item/publish/publishedItem.cy.ts @@ -73,7 +73,7 @@ const waitOnItemValidation = (item: PackedItem) => { const waitOnPublishItem = ( item: PackedItem, - { shouldNotify }: { shouldNotify: boolean } = { shouldNotify: false }, + { shouldNotify = false }: { shouldNotify?: boolean } = {}, ) => { cy.wait('@publishItem').then((data) => { const { From 606d5511e4d62cb26d30c4b0dee849aa78270e9b Mon Sep 17 00:00:00 2001 From: spaenleh Date: Wed, 25 Feb 2026 09:36:31 +0100 Subject: [PATCH 4/5] fix: remove unnecessary casting --- .../e2e/builder/item/publish/publishedItem.cy.ts | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/cypress/e2e/builder/item/publish/publishedItem.cy.ts b/cypress/e2e/builder/item/publish/publishedItem.cy.ts index 9769b6789..9fac86757 100644 --- a/cypress/e2e/builder/item/publish/publishedItem.cy.ts +++ b/cypress/e2e/builder/item/publish/publishedItem.cy.ts @@ -149,9 +149,7 @@ describe('Private Item', () => { describe('Ready to Publish Item', () => { const status = PublicationStatus.ReadyToPublish; - const itemValidationGroup = ItemValidationGroupFactory( - privateItem, - ) as ItemValidationGroup; + const itemValidationGroup = ItemValidationGroupFactory(privateItem); beforeEach(() => { setUpAndVisitItemPage(privateItem, { @@ -179,7 +177,7 @@ describe('Private Item', () => { const status = PublicationStatus.Invalid; const itemValidationGroup = ItemValidationGroupFactory(privateItem, { status: ItemValidationStatus.Failure, - }) as ItemValidationGroup; + }); beforeEach(() => { setUpAndVisitItemPage(privateItem, { @@ -231,7 +229,7 @@ describe('Public Item', () => { const status = PublicationStatus.Pending; const itemValidationGroup = ItemValidationGroupFactory(publicItem, { status: ItemValidationStatus.Pending, - }) as ItemValidationGroup; + }); beforeEach(() => { setUpAndVisitItemPage(PublishedItemFactory(publicItem), { @@ -256,9 +254,7 @@ describe('Public Item', () => { describe('Ready to Publish Item', () => { const status = PublicationStatus.ReadyToPublish; - const itemValidationGroup = ItemValidationGroupFactory( - publicItem, - ) as ItemValidationGroup; + const itemValidationGroup = ItemValidationGroupFactory(publicItem); beforeEach(() => { setUpAndVisitItemPage(publicItem, { @@ -288,9 +284,7 @@ describe('Public Item', () => { describe('Published Item', () => { const status = PublicationStatus.Published; - const itemValidationGroup = ItemValidationGroupFactory( - publicItem, - ) as ItemValidationGroup; + const itemValidationGroup = ItemValidationGroupFactory(publicItem); beforeEach(() => { setUpAndVisitItemPage(PublishedItemFactory(publicItem), { From d09b456ccc7d27e48c750d2e01975ca50c4dc44d Mon Sep 17 00:00:00 2001 From: spaenleh Date: Thu, 26 Feb 2026 10:26:05 +0100 Subject: [PATCH 5/5] fix: remove fix for node:path since webpack exploses --- cypress/e2e/builder/item/download/downloadItem.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cypress/e2e/builder/item/download/downloadItem.cy.ts b/cypress/e2e/builder/item/download/downloadItem.cy.ts index c8a7ad4a2..4774b4f82 100644 --- a/cypress/e2e/builder/item/download/downloadItem.cy.ts +++ b/cypress/e2e/builder/item/download/downloadItem.cy.ts @@ -6,7 +6,7 @@ import { PackedFolderItemFactory, } from '@graasp/sdk'; -import path from 'node:path'; +import path from 'path'; import { buildDataCyWrapper,