From e764329134e7c035c8485e032b0f4c5aa39c0e6a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 3 Apr 2022 19:23:52 +0000 Subject: [PATCH] Bump actions/setup-node from 2.5.1 to 3.1.0 Bumps [actions/setup-node](https://github.com/actions/setup-node) from 2.5.1 to 3.1.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](https://github.com/actions/setup-node/compare/1f8c6b94b26d0feae1e387ca63ccbdc44d27b561...5b52f097d36d4b0b2f94ed6de710023fbb8b2236) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/autoupdate-branch.yml | 2 +- .github/workflows/azure-prod-build-deploy.yml | 2 +- .github/workflows/browser-test.yml | 2 +- .github/workflows/check-all-english-links.yml | 2 +- .../check-broken-links-github-github.yml | 2 +- .github/workflows/code-lint.yml | 2 +- .../content-changes-table-comment.yml | 2 +- .../workflows/create-translation-batch-pr.yml | 2 +- .github/workflows/crowdin-cleanup.yml | 2 +- .github/workflows/docs-review-collect.yml | 2 +- .github/workflows/enterprise-dates.yml | 2 +- .../enterprise-release-sync-search-index.yml | 2 +- .github/workflows/link-check-all.yml | 2 +- .github/workflows/open-enterprise-issue.yml | 2 +- .github/workflows/openapi-decorate.yml | 2 +- .github/workflows/openapi-schema-check.yml | 2 +- .github/workflows/orphaned-assets-check.yml | 42 ++++++++++++++++--- .github/workflows/os-ready-for-review.yml | 2 +- .github/workflows/pa11y.yml | 2 +- .github/workflows/package-lock-lint.yml | 2 +- .github/workflows/ready-for-doc-review.yml | 2 +- .github/workflows/remove-unused-assets.yml | 2 +- .github/workflows/repo-sync.yml | 2 +- .github/workflows/sync-search-indices.yml | 14 ++++++- .github/workflows/sync-search-pr.yml | 2 +- .github/workflows/test.yml | 9 +++- .../triage-unallowed-internal-changes.yml | 2 +- .github/workflows/update-graphql-files.yml | 2 +- 28 files changed, 81 insertions(+), 34 deletions(-) diff --git a/.github/workflows/autoupdate-branch.yml b/.github/workflows/autoupdate-branch.yml index 04347e99952a..7e36e1a69b86 100644 --- a/.github/workflows/autoupdate-branch.yml +++ b/.github/workflows/autoupdate-branch.yml @@ -43,7 +43,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/azure-prod-build-deploy.yml b/.github/workflows/azure-prod-build-deploy.yml index 2a10b09863bc..a8607c2fc83d 100644 --- a/.github/workflows/azure-prod-build-deploy.yml +++ b/.github/workflows/azure-prod-build-deploy.yml @@ -60,7 +60,7 @@ jobs: run: git lfs checkout - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/browser-test.yml b/.github/workflows/browser-test.yml index 14b0e3de1bc7..ea6a05322978 100644 --- a/.github/workflows/browser-test.yml +++ b/.github/workflows/browser-test.yml @@ -40,7 +40,7 @@ jobs: run: git lfs checkout - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/check-all-english-links.yml b/.github/workflows/check-all-english-links.yml index a405461ff20d..2ade89b1cbc2 100644 --- a/.github/workflows/check-all-english-links.yml +++ b/.github/workflows/check-all-english-links.yml @@ -28,7 +28,7 @@ jobs: - name: Check out repo's default branch uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/check-broken-links-github-github.yml b/.github/workflows/check-broken-links-github-github.yml index 4a07615b3a09..939647801739 100644 --- a/.github/workflows/check-broken-links-github-github.yml +++ b/.github/workflows/check-broken-links-github-github.yml @@ -42,7 +42,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/code-lint.yml b/.github/workflows/code-lint.yml index ac204f64845a..43c89e07c520 100644 --- a/.github/workflows/code-lint.yml +++ b/.github/workflows/code-lint.yml @@ -37,7 +37,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/content-changes-table-comment.yml b/.github/workflows/content-changes-table-comment.yml index 2584ca9cf9ee..d83b15dcd6b3 100644 --- a/.github/workflows/content-changes-table-comment.yml +++ b/.github/workflows/content-changes-table-comment.yml @@ -57,7 +57,7 @@ jobs: run: .github/actions-scripts/get-preview-app-info.sh - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/create-translation-batch-pr.yml b/.github/workflows/create-translation-batch-pr.yml index 3aa683d75be5..2b7c47ba3aeb 100644 --- a/.github/workflows/create-translation-batch-pr.yml +++ b/.github/workflows/create-translation-batch-pr.yml @@ -116,7 +116,7 @@ jobs: git commit -m "Add crowdin translations" || echo "Nothing to commit" - name: 'Setup node' - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x diff --git a/.github/workflows/crowdin-cleanup.yml b/.github/workflows/crowdin-cleanup.yml index d378461d778b..9bb4d81d1135 100644 --- a/.github/workflows/crowdin-cleanup.yml +++ b/.github/workflows/crowdin-cleanup.yml @@ -29,7 +29,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/docs-review-collect.yml b/.github/workflows/docs-review-collect.yml index ee6733392bbe..21451625dd44 100644 --- a/.github/workflows/docs-review-collect.yml +++ b/.github/workflows/docs-review-collect.yml @@ -23,7 +23,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/enterprise-dates.yml b/.github/workflows/enterprise-dates.yml index c4a92b101cd8..89570a8ea08e 100644 --- a/.github/workflows/enterprise-dates.yml +++ b/.github/workflows/enterprise-dates.yml @@ -39,7 +39,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/enterprise-release-sync-search-index.yml b/.github/workflows/enterprise-release-sync-search-index.yml index 3a3545727207..62b65fa85233 100644 --- a/.github/workflows/enterprise-release-sync-search-index.yml +++ b/.github/workflows/enterprise-release-sync-search-index.yml @@ -50,7 +50,7 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index eeec776e09fd..a26145208c24 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -30,7 +30,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/open-enterprise-issue.yml b/.github/workflows/open-enterprise-issue.yml index 2e0dcac1cf1c..99569ea7137e 100644 --- a/.github/workflows/open-enterprise-issue.yml +++ b/.github/workflows/open-enterprise-issue.yml @@ -22,7 +22,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/openapi-decorate.yml b/.github/workflows/openapi-decorate.yml index a77301d3934d..f13d9d60254d 100644 --- a/.github/workflows/openapi-decorate.yml +++ b/.github/workflows/openapi-decorate.yml @@ -42,7 +42,7 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/openapi-schema-check.yml b/.github/workflows/openapi-schema-check.yml index 128adec955b3..dfbb6c20f78d 100644 --- a/.github/workflows/openapi-schema-check.yml +++ b/.github/workflows/openapi-schema-check.yml @@ -42,7 +42,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/orphaned-assets-check.yml b/.github/workflows/orphaned-assets-check.yml index c300159f4677..80a3b90e914a 100644 --- a/.github/workflows/orphaned-assets-check.yml +++ b/.github/workflows/orphaned-assets-check.yml @@ -5,23 +5,27 @@ name: 'Orphaned assets check' # **Who does it impact**: Docs content. on: - pull_request: - push: - branches: - - gh-readonly-queue/main/** + workflow_dispatch: + schedule: + - cron: '13 10 * * *' # Once a day at 10:13 UTC permissions: contents: read jobs: orphaned-assets-check: + if: ${{ github.repository == 'github/docs-internal' }} runs-on: ubuntu-latest steps: - name: Checkout uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 + with: + # Using a PAT is necessary so that the new commit will trigger the + # CI in the PR. (Events from GITHUB_TOKEN don't trigger new workflows.) + token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm @@ -30,4 +34,30 @@ jobs: run: npm ci - name: Check for orphaned assets - run: ./script/find-orphaned-assets.mjs --verbose --exit + env: + # Needed for gh + GITHUB_TOKEN: ${{ secrets.DOCUBOT_REPO_PAT }} + run: | + set -e + + ./script/find-orphaned-assets.mjs | xargs git rm + + # If nothing to commit, exit now. It's fine. No orphans. + git status | grep 'nothing to commit' && exit 0 + + # Replicated from the translation pipeline PR-maker Action + git config --global user.name "docubot" + git config --global user.email "67483024+docubot@users.noreply.github.com" + + date=$(date '+%Y-%m-%d-%H-%M') + branchname=orphaned-assets-$date-$GITHUB_RUN_ID + + git checkout -b $branchname + git commit -m "Delete orphaned assets $date" + git push origin $branchname + + gh pr create \ + --title "Delete orphaned assets ($date)" \ + --body "Found with the find-orphaned-assets.mjs script" \ + --repo github/docs-internal \ + --label docs-content-fr diff --git a/.github/workflows/os-ready-for-review.yml b/.github/workflows/os-ready-for-review.yml index 673e11627ca2..27ebb9a5fde4 100644 --- a/.github/workflows/os-ready-for-review.yml +++ b/.github/workflows/os-ready-for-review.yml @@ -47,7 +47,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml index 8babbfa8d827..ce0f316d1003 100644 --- a/.github/workflows/pa11y.yml +++ b/.github/workflows/pa11y.yml @@ -21,7 +21,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/package-lock-lint.yml b/.github/workflows/package-lock-lint.yml index c045acfdc158..395504d25444 100644 --- a/.github/workflows/package-lock-lint.yml +++ b/.github/workflows/package-lock-lint.yml @@ -27,7 +27,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x diff --git a/.github/workflows/ready-for-doc-review.yml b/.github/workflows/ready-for-doc-review.yml index 416ade584193..2372b9562903 100644 --- a/.github/workflows/ready-for-doc-review.yml +++ b/.github/workflows/ready-for-doc-review.yml @@ -23,7 +23,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/remove-unused-assets.yml b/.github/workflows/remove-unused-assets.yml index 68469cb2a01b..ff2ccdcef7a4 100644 --- a/.github/workflows/remove-unused-assets.yml +++ b/.github/workflows/remove-unused-assets.yml @@ -27,7 +27,7 @@ jobs: - name: Checkout uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/repo-sync.yml b/.github/workflows/repo-sync.yml index a3f975f356a3..9821a404ffaf 100644 --- a/.github/workflows/repo-sync.yml +++ b/.github/workflows/repo-sync.yml @@ -102,7 +102,7 @@ jobs: # Set up npm and run npm ci to run husky to get githooks for LFS - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/sync-search-indices.yml b/.github/workflows/sync-search-indices.yml index 00f8d73595de..5d57cbc0296b 100644 --- a/.github/workflows/sync-search-indices.yml +++ b/.github/workflows/sync-search-indices.yml @@ -56,7 +56,7 @@ jobs: token: ${{ secrets.DOCS_BOT_FR }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm @@ -77,6 +77,18 @@ jobs: env: VERSION: ${{ github.event.inputs.version }} LANGUAGE: ${{ github.event.inputs.language }} + # We don't want or need the changelog entries in this context. + # Pages that display the content from these isn't included + # in search index bodies anyway. + CHANGELOG_DISABLED: true + # If a reusable, or anything in the `data/*` directory is deleted + # you might get a + # + # RenderError: Can't find the key 'site.data.reusables...' in the scope + # + # But that'll get fixed in the next translation pipeline. For now, + # let's just accept an empty string instead. + THROW_ON_EMPTY: false run: npm run sync-search - name: Update private docs repository search indexes diff --git a/.github/workflows/sync-search-pr.yml b/.github/workflows/sync-search-pr.yml index 339dec87148d..f5f4182cefa8 100644 --- a/.github/workflows/sync-search-pr.yml +++ b/.github/workflows/sync-search-pr.yml @@ -29,7 +29,7 @@ jobs: uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7b4669893db5..ed3eaff0081b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -48,7 +48,10 @@ jobs: - name: Check out repo uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 with: - lfs: true + # Not all test suites need the LFS files. So instead, we opt to + # NOT clone them initially and instead, include them manually + # only for the test groups that we know need the files. + lfs: ${{ matrix.test-group == 'content' }} # Enables cloning the Early Access repo later with the relevant PAT persist-credentials: 'false' @@ -99,6 +102,8 @@ jobs: mv docs-early-access/data data/early-access rm -r docs-early-access + # This is necessary when LFS files where cloned but does nothing + # if actions/checkout was run with `lfs:false`. - name: Checkout LFS objects run: git lfs checkout @@ -118,7 +123,7 @@ jobs: echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/triage-unallowed-internal-changes.yml b/.github/workflows/triage-unallowed-internal-changes.yml index 00299d1ca82f..e5bf70fc7aa4 100644 --- a/.github/workflows/triage-unallowed-internal-changes.yml +++ b/.github/workflows/triage-unallowed-internal-changes.yml @@ -61,7 +61,7 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm diff --git a/.github/workflows/update-graphql-files.yml b/.github/workflows/update-graphql-files.yml index 454514bfe81a..c9f555c23d19 100644 --- a/.github/workflows/update-graphql-files.yml +++ b/.github/workflows/update-graphql-files.yml @@ -34,7 +34,7 @@ jobs: - name: Checkout uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@5b52f097d36d4b0b2f94ed6de710023fbb8b2236 with: node-version: 16.14.x cache: npm