Proposal: switch to smarthome rest api (or enhance by using rest api request in some places)

[rotdrop]

Hi there,

thank you for this nice piece of software!

As of now there is also a REST API accessible via /api/v0/smarthome/ and documented here:

https://fritz.com/pages/schnittstellen

It seems that the REST API offers more control over the smarthome devices than the odler AHA API, it is, e.g., possible to set the temperature offset of the 302 thermostats through the REST API (but not with AHA).

So the proposal would be to enhance pyfritzhome by also using the REST API in places where the AHA API offers less control than the REST API.

[mib1185]

Hi @rotdrop
Im already thinking about to implement the new REST API into the library (but keep the AHA API as fallback for older Fritzbox models), but that's not an easy task and will last some time

[rotdrop]

Hi @mib1185,

thank you for the quick answer. I actually suspected that this was already on your mind. The REST API is quite new. Keep on with your good work! I am looking forward for changes in that direction, but yes: coding takes time.

[kugel-]

Hello. Just FYI, I started working on a REST version of this library. The "temperature offset of the 302" use case triggered me as well.

However, I decided to drop the AHA-API support since REST API is supported on basically all models anyway, if they run a recent enough firmware. Supporting both is going to be a pain. Could we maybe snapshot the current code in some namespace activate at runtime (AHA-API is not going to get any new extensions, therefore we probably don't have to touch it anymore).

However, I try to keep the interface for the library users more or less the same.

I didn't progress enough yet to share code but I will hopefully be able to publish my fork within the next week or so. My wish would be to get this integrated here, so I hope you'll like it.

[mib1185]

For reasons of sustainability, I don't think we should drop the AHA API support, as many older (but still working) boxes do not get the rest api anymore.

[kugel-]

I don't necessarily disagree, but it's a lot of work. Since the APIs don't really play together I don't really see how to possibly provide a unified interface for fritzhome users.

I try to keep that in mind, so that I hopefully don't diverge too much. But let me first try achieve feature partity, and then look how to bring back aha API support. I already look intensively on how HA uses fritzhome.

Unfortunately REST API is different enough to make it unrealistic to make the switch transparently. Pretty sure some (hopefully small) client-side adaptions are inevitable.

PS: I have made some progress the last 2 weeks but it's going slowly.