Skip to content

visualize element shows previously filtered elements in grey #239

@naronchen

Description

@naronchen

Example to reproduce:

going into VersionCompareTesting, select OpenPlant3, select version r3 to compare with.
go in processPhysicalModel -> toggle off Added and Removed in the filter -> inspect changes in 1-SWS-0104-1C [3-59] -> inspect changes in 1-SWS-0104-1C-seg-1 [3-SA]

Image

should be able to see these 3 elements being highlighted

continue to inspect 50-FV-0001

Observed behaviour

Image
previously hidden added elements now shows up in grey.

Cause

This is introduced by this PR
It wasnt an issue before since everything just gets greyed out instead of hidden previously

the problem is the set of treeNodes passing into the filter function in EnhancedElementsInspector dont include the parents anymore when inspecting element 50-FV-0001. So the provider doesnt know what to hide.

Ideas to fix

Maybe need sth to persist the hidden elements list? or the child treenode should traverse to its parents and get the what should be hidden?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions