libfq build error on Fedora 42

[devrimgunduz]

Hi @ibarwick ,

I'm seeing the following while building latest libfq on Fedora 42. Can you please take a look? Thanks! Devrim

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./include -I./include -I/usr/include/firebird -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MT src/fqmultibyte.lo -MD -MP -MF src/.deps/fqmultibyte.Tpo -c src/fqmultibyte.c -o src/fqmultibyte.o >/dev/null 2>&1
In file included from src/fqexpbuffer.c:30:
./include/libfq.h:13:14: error: ‘bool’ cannot be defined via ‘typedef’
   13 | typedef char bool;
      |              ^~~~
./include/libfq.h:13:14: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
./include/libfq.h:13:1: warning: useless type name in empty declaration
   13 | typedef char bool;
      | ^~~~~~~
make[2]: *** [Makefile:540: src/fqexpbuffer.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from src/libfq.c:42:
./include/libfq.h:13:14: error: ‘bool’ cannot be defined via ‘typedef’
   13 | typedef char bool;
      |              ^~~~
./include/libfq.h:13:14: note: ‘bool’ is a keyword with ‘-std=c23’ onwards
./include/libfq.h:13:1: warning: useless type name in empty declaration
   13 | typedef char bool;
      | ^~~~~~~
src/libfq.c: In function ‘_FQformatDatum’:
src/libfq.c:3632:57: warning: pointer targets in passing argument 1 of ‘_FQformatOctet’ differ in signedness [-Wpointer-sign]
 3632 |                                 p = _FQformatOctet(vary2->vary_string, vary2->vary_length);
      |                                                    ~~~~~^~~~~~~~~~~~~
      |                                                         |
      |                                                         ISC_UCHAR * {aka unsigned char *}
src/libfq.c:139:35: note: expected ‘char *’ but argument is of type ‘ISC_UCHAR *’ {aka ‘unsigned char *’}
  139 | static char *_FQformatOctet(char *data, int len);
      |                             ~~~~~~^~~~
make[2]: *** [Makefile:540: src/libfq.lo] Error 1
make[2]: Leaving directory '/var/lib/pgsql/rpmcommon/BUILD/libfq-0.6.1-build/libfq-0.6.1'
make[1]: *** [Makefile:585: all-recursive] Error 1
make[1]: Leaving directory '/var/lib/pgsql/rpmcommon/BUILD/libfq-0.6.1-build/libfq-0.6.1'
error: Bad exit status from /var/tmp/rpm-tmp.9HK7xS (%build)

[ibarwick]

Hi Devrim,
Thanks for the notification, I'll take a look.

[ibarwick]

Hi @devrimgunduz

I've pushed a couple of fixes which should resolve the reported issues.

Ian

[devrimgunduz-edb]

Hi @ibarwick ,

Thank you! Build passes, but I see a warning. Does this one also need a patch? Thanks! Devrim

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I./include -I./include -I/usr/include/firebird -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MT src/fqexpbuffer.lo -MD -MP -MF src/.deps/fqexpbuffer.Tpo -c src/fqexpbuffer.c -o src/fqexpbuffer.o >/dev/null 2>&1
src/libfq.c: In function ‘FQconnectdbParams’:
src/libfq.c:296:9: warning: ‘__strncpy_chk’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  296 |         strncpy(conn->db_path, db_path, db_path_len);
      |         ^
src/libfq.c:294:23: note: length computed here
  294 |         db_path_len = strlen(db_path);
      |                       ^~~~~~~~~~~~~~~
src/libfq.c:307:17: warning: ‘__strncpy_chk’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  307 |                 strncpy(conn->uname, uname, uname_len);
      |                 ^
src/libfq.c:302:33: note: length computed here
  302 |                 int uname_len = strlen(uname);
      |                                 ^~~~~~~~~~~~~
src/libfq.c:318:17: warning: ‘__strncpy_chk’ output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
  318 |                 strncpy(conn->upass, upass, upass_len);
      |                 ^
src/libfq.c:313:33: note: length computed here
  313 |                 int upass_len = strlen(upass);
      |                                 ^~~~~~~~~~~~~

[devrimgunduz]

@ibarwick ^^

[ibarwick]

@devrimgunduz @devrimgunduz-edb

Build passes, but I see a warning. Does this one also need a patch?

Fancy new compiler does not know I set my string NUL terminators in the olde skool way. Code now updated to keep fancy new compiler happy. Apologies for the deiay.

[devrimgunduz]

Will you release a new version?

[ibarwick]

@devrimgunduz probably, looks like we're due 0.7.0. Can't promise a date right now.

[devrimgunduz]

@ibarwick ping :)