bug(import): Resuming completed import returns 'already running' error

[caterryan]

Summary

Resuming a completed import returns "Import is already running" instead of "Import is already completed".

Steps to Reproduce

1. Start an import and let it complete successfully
2. Verify status shows overall_status: "completed"
3. Attempt to resume the completed import
4. Observe error says "already running" instead of "already completed"

Expected Behavior

{
  "status": "error",
  "error": "Import <id> is already completed"
}

Actual Behavior

{
  "status": "error",
  "error": "Import <id> is already running"
}

[caterryan]

Additional ai generated context

Root Cause

In resume_import() (lines 2339-2349), the code checks pause state before checking completion status:

# Line 2339-2349
pause_state = get_import_pause_state(influxdb3_local, import_id, task_id)

if pause_state == ImportPauseState.NOT_FOUND:
    return {"status": "error", "error": f"Import {import_id} not found"}

if pause_state == ImportPauseState.CANCELLED:
    return {"status": "error", "error": f"Import {import_id} was cancelled and cannot be resumed"}

if pause_state == ImportPauseState.RUNNING:  # <-- This triggers for completed imports!
    return {"status": "error", "error": f"Import {import_id} is already running"}

The get_import_pause_state() function only checks the import_pause_state table for paused and canceled flags. A completed import has paused=false, canceled=false, which returns ImportPauseState.RUNNING.

The completion check exists later in the code (lines 2375-2381), but it's never reached because the "already running" error returns first.

Proposed Fix

Option A: Check completion status before pause state

def resume_import(...):
    # Check if import exists and is completed FIRST
    status_query = f"""
    SELECT status, table_name
    FROM 'import_state'
    WHERE import_id = '{import_id}'
    ORDER BY time DESC
    LIMIT 100
    """
    status_result = influxdb3_local.query(status_query)

    if not status_result:
        return {"status": "error", "error": f"Import {import_id} not found"}

    # Check if all tables are completed
    latest_states = {}
    for row in status_result:
        table_name = row.get("table_name")
        if table_name not in latest_states:
            latest_states[table_name] = row.get("status")

    non_completed_tables = [
        table for table, status in latest_states.items()
        if table != "all" and status not in ["completed", "cancelled"]
    ]

    if not non_completed_tables:
        return {"status": "error", "error": f"Import {import_id} is already completed"}

    # THEN check pause state
    pause_state = get_import_pause_state(...)
    # ... rest of logic

Option B: Add COMPLETED state to ImportPauseState enum and update get_import_pause_state() to check import_state table

Affected Code

• File: import.py
• Function: resume_import()
• Lines: 2339-2349

[caterryan]

related #47