[BUG]: `github_repository_collaborators` error on repository rename

[acouvreur]

Expected Behavior

The github_repository_collaborators has the property repository which is used as the resource ID.

But changing a the repository property on a github_repository_collaborators can mean two things:

• the collaborators are no longer assigned to the previous repository, and are now assigned to the new repository
• the repository has been renamed

The ID should be set to the repository ID to properly delete the collaborators only of the ID changed.

Actual Behavior

The first case will work, the second will fail because it can no longer remove that repository by name from the collaborators.

Terraform Version

Terraform v1.13.3
on darwin_arm64

• provider registry.terraform.io/integrations/github v6.6.0

Affected Resource(s)

• github_repository_collaborators

Terraform Configuration Files

Steps to Reproduce

No response

Debug Output

Panic Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[acouvreur]

I have created a first draft for this change: #2876

However, I don't think making API calls should be part of a refresh strategy when we can simply replace repository with repository_id.

Then, when adding or removing the collaborators, query the repository name because the API does not provide such call through repository ID.

[acouvreur]

Another even simpler solution is to swallow 404 errors not found on deletion when calling client.Repositories.RemoveCollaborator

[stevehipwell]

@acouvreur is there a reason you can't use the Mutable Identities field?

[acouvreur]

@acouvreur is there a reason you can't use the Mutable Identities field?

I was not aware of it! I'll take a look into it

[deiga]

@stevehipwell Would your PR #3068 be solving this issue?