Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Build failure with glibc 2.28, released Aug 1 #25

@jamespharvey20

Description

@jamespharvey20

As of glibc 2.28:

  • The macros 'major', 'minor', and 'makedev' are now only available from
    the header <sys/sysmacros.h>; not from <sys/types.h> or various other
    headers that happen to include <sys/types.h>. These macros are rarely
    used, not part of POSIX nor XSI, and their names frequently collide with
    user code; see https://sourceware.org/bugzilla/show_bug.cgi?id=19239 for
    further explanation.

    <sys/sysmacros.h> is a GNU extension. Portable programs that require
    these macros should first include <sys/types.h>, and then include
    <sys/sysmacros.h> if GNU_LIBRARY is defined.

This causes:

ipath_proto.c: In function ‘ipath_userinit’:
ipath_proto.c:539:32: error: implicit declaration of function ‘minor’; did you mean ‘mincore’? [-Werror=implicit-function-declaration]
     spctrl->spc_dev.spd_type = minor(st.st_rdev);
                                ^~~~~
                                mincore

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions