Return value of EI when variance is zero

[ngiann]

Similarly to a previous issue #21

BayesianOptimization.jl/src/acquisitionfunctions.jl

Line 48 in 5ce078b

σ² == 0 && return μ > a.τ ? μ - a.τ : 0.

I noticed that given that the variance is 0 you may return `μ - a.τ`` if this difference is positive and otherwise 0.
However, I see that equation (4) in "A Tutorial on Bayesian Optimization of..." the return value of EI is always zero if the variance is zero.

Cheers

[jbrea]

The limit of EI for σ² to 0 is μ > a.τ ? μ - a.τ : 0., because the second term vanishes and the cdf in the first term approaches 1 when μ > a.τ and 0 otherwise. I think the comment "... and vanishes otherwise" in the tutorial is misleading.