From b6546c220b23f3a4d06f86edb842e58a2986f52c Mon Sep 17 00:00:00 2001 From: Marco Garzola Date: Thu, 22 Dec 2022 13:50:57 +0100 Subject: [PATCH 1/2] Update __init__.py fix missing update_service zeroconf callback --- homekit/zeroconf_impl/__init__.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/homekit/zeroconf_impl/__init__.py b/homekit/zeroconf_impl/__init__.py index 287192b..eddf8db 100644 --- a/homekit/zeroconf_impl/__init__.py +++ b/homekit/zeroconf_impl/__init__.py @@ -40,7 +40,10 @@ def add_service(self, zeroconf, zeroconf_type, name): info = zeroconf.get_service_info(zeroconf_type, name) if info is not None: self.data.append(info) - + + def update_service(self, zc: "zeroconf.Zeroconf", type_: str, name: str) -> None: + """Callback for state updates, which we ignore for now.""" + def get_data(self): """ Use this method to get the data of the collected announcements. From 257ea734653cb6f77f81473ee651be1338b30e55 Mon Sep 17 00:00:00 2001 From: Marco Garzola Date: Mon, 23 Jan 2023 08:24:12 +0100 Subject: [PATCH 2/2] Update __init__.py remove old update_service in zeroconf --- homekit/zeroconf_impl/__init__.py | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/homekit/zeroconf_impl/__init__.py b/homekit/zeroconf_impl/__init__.py index eddf8db..dca68b3 100644 --- a/homekit/zeroconf_impl/__init__.py +++ b/homekit/zeroconf_impl/__init__.py @@ -52,19 +52,6 @@ def get_data(self): """ return self.data - def update_service(self, zeroconf, service_type, name, state_change): - # prevent FutureWarning: XXX has no update_service method. Provide one - # (it can be empty if you don't care about the updates), it'll become - # mandatory. - logging.debug( - 'update_service zeroconf=%s service_type=%s name=%s state_change=%s', - zeroconf, - service_type, - name, - state_change, - ) - - def get_from_properties(props, key, default=None, case_sensitive=True): """ This function looks up the key in the given zeroconf service information properties. Those are a dict between bytes.