DropObject.Sort is done too early in SchemaInstaller.Install

[jeroenbu]

Hi,

In Insight.Database.Schema.SchemaInstaller context.DropObjects.Sort((e1, e2) => -CompareByInstallOrder(e1, e2)); is done too early. Right now the DropObjects are sorted, and in the codeblock for anything that's not entirely new the DropObject collection can be modified, resulting in a possible incorrect sortorder.
Solution is to place the DropObject.Sort on a line following the code block for anything that's not entirely new; right next to the sort of the AddObject will do just fine.

Thx,

Jeroen

[jorgeyanesdiez]

@jeroenbu did you run into a problem with this? I'm considering forking this tool and I'm curious.

[jeroenbu]

@jorgeyanesdiez I probably did run into a problem, since I opened this issue... :P However, since this is quite some time ago, I don't really recall what exactly was the situation I experienced it in.
Insight.Database.Schema-master.zip
I attached the sourcefiles which I changed to have it work in my situation; I'm not entirely sure if I made a change re this issue. I did'n fork the code myself as I really don't feel qualified to actually change this code for others. :) But feel free to take any good changes from it.

Thx,

Jeroen

[jorgeyanesdiez]

Thanks @jeroenbu, I'll let you know if I fork.