-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Overview
The sandbox developer tools currently expose a "Show on Device" option only for Ethereum in the Get Address flow. When enabled, this displays the derived address on the hardware device screen for user verification—a useful security feature for confirming the correct address before use.
All other chains (Bitcoin, Cosmos, Litecoin, Dogecoin, Ripple, THORChain) hardcode showDisplay: false in their Get Address tools and do not offer this option to users. The underlying HD wallet APIs already support showDisplay for these chains, so this is purely a UI/UX gap in the sandbox.
References and additional details
Current implementation (Ethereum only):
examples/sandbox/developerTools.ts— Ethereum Get Address tool (lines ~276–310) includes a "Show on Device" select input and passesshowDisplayfrom user selection towallet.ethGetAddress().
Chains to update:
- Bitcoin (
btc-address) — usesbtcGetAddress, supportsshowDisplayinpackages/hdwallet-core/src/bitcoin.ts - Cosmos (
cosmos-address) — usescosmosGetAddress, supportsshowDisplayinpackages/hdwallet-core/src/cosmos.ts - Litecoin (
ltc-address) — usesbtcGetAddresswithcoin: 'Litecoin', supportsshowDisplay - Dogecoin (
doge-address) — usesbtcGetAddresswithcoin: 'Dogecoin', supportsshowDisplay - Ripple (
ripple-address) — usesrippleGetAddress, supportsshowDisplayinpackages/hdwallet-core/src/ripple.ts - THORChain (
thorchain-address) — usesthorchainGetAddress, supportsshowDisplayinpackages/hdwallet-core/src/thorchain.ts
Pattern to follow: Add an input to each Get Address tool matching Ethereum's:
{
id: '<chain>-addr-display',
label: 'Show on Device',
type: 'select',
options: [
{ value: 'false', label: 'No' },
{ value: 'true', label: 'Yes' }
]
}Then read the value and pass showDisplay: ($('#<chain>-addr-display') as any).val() === 'true' to the respective getAddress call.
Acceptance Criteria
- Bitcoin Get Address includes "Show on Device" (Yes/No) option
- Cosmos Get Address includes "Show on Device" (Yes/No) option
- Litecoin Get Address includes "Show on Device" (Yes/No) option
- Dogecoin Get Address includes "Show on Device" (Yes/No) option
- Ripple Get Address includes "Show on Device" (Yes/No) option
- THORChain Get Address includes "Show on Device" (Yes/No) option
- When "Yes" is selected, the address is displayed on the hardware device screen
- Result output includes whether the address was shown on device (consistent with Ethereum:
Shown on device: Yes/No)
Need By Date
N/A
Screenshots/Mockups
N/A — UI change mirrors existing Ethereum Get Address behavior.
Estimated effort
1 hour