From dd224dab10913c2b46fb4c46179e80644eff105b Mon Sep 17 00:00:00 2001 From: Tanmay Sardesai Date: Tue, 10 Feb 2026 16:08:43 -0800 Subject: [PATCH 1/2] feat: accept pool name as positional arg in browser-pools create Allow `kernel browser-pools create my-pool` as shorthand for `kernel browser-pools create --name my-pool`. The --name flag still works for backward compatibility. Co-authored-by: Cursor --- cmd/browser_pools.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/cmd/browser_pools.go b/cmd/browser_pools.go index 91dd1eb..1f2fd67 100644 --- a/cmd/browser_pools.go +++ b/cmd/browser_pools.go @@ -404,8 +404,9 @@ var browserPoolsListCmd = &cobra.Command{ } var browserPoolsCreateCmd = &cobra.Command{ - Use: "create", + Use: "create [name]", Short: "Create a new browser pool", + Args: cobra.MaximumNArgs(1), RunE: runBrowserPoolsCreate, } @@ -517,7 +518,11 @@ func runBrowserPoolsList(cmd *cobra.Command, args []string) error { func runBrowserPoolsCreate(cmd *cobra.Command, args []string) error { client := getKernelClient(cmd) + // Name can be provided as positional argument or via --name flag name, _ := cmd.Flags().GetString("name") + if len(args) > 0 && args[0] != "" { + name = args[0] + } size, _ := cmd.Flags().GetInt64("size") fillRate, _ := cmd.Flags().GetInt64("fill-rate") timeout, _ := cmd.Flags().GetInt64("timeout") From 46881b10fe1382771ca91a16cfe118d3ffc8406a Mon Sep 17 00:00:00 2001 From: Tanmay Sardesai Date: Tue, 10 Feb 2026 16:25:55 -0800 Subject: [PATCH 2/2] fix: error when pool name is passed both as arg and --name flag Co-authored-by: Cursor --- cmd/browser_pools.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/browser_pools.go b/cmd/browser_pools.go index 1f2fd67..79a19c8 100644 --- a/cmd/browser_pools.go +++ b/cmd/browser_pools.go @@ -518,9 +518,11 @@ func runBrowserPoolsList(cmd *cobra.Command, args []string) error { func runBrowserPoolsCreate(cmd *cobra.Command, args []string) error { client := getKernelClient(cmd) - // Name can be provided as positional argument or via --name flag name, _ := cmd.Flags().GetString("name") if len(args) > 0 && args[0] != "" { + if cmd.Flags().Changed("name") { + return fmt.Errorf("cannot specify pool name as both a positional argument and --name flag") + } name = args[0] } size, _ := cmd.Flags().GetInt64("size")