URL Query variable does not work with .

[gcw07]

I'm trying to do a GET with a query variable being:

?api.version=1

Because of parse_str called in parseQueryParams method, it converts that variable to:

?api_version=1

I'm sure you had a reason for parse_str, so zttp might just not work for me, but thought I'd report it in case that was an unintended problem. Thanks.

[adamwathan]

Can you share the code you're using to do this so I can replicate and play with it? There's two ways to send query parameters with Zttp and not sure which way you're using.

[gcw07]

Sure. I was just sending them on the url:

$url = "{$this->baseUrl}/getdiskusage?api.version=1";

$response = Zttp::withHeaders([
    'Authorization' => "whm username:api-token"
])->withoutVerifying()->get($url);

dd($response->json());

This is what I ended up having work in just plain Guzzle:

$client = new \GuzzleHttp\Client();

$response = $client->request('GET', $url, [
       'headers' => ['Authorization' => "whm username:api-token"],
       'verify'  => false,
       'connect_timeout' => 10
]);

return json_decode($response->getBody(), true);

Thanks.

[sixlive]

@adamwathan I tossed together some failing tests (here).

Both ways of passing the parameters fail. Outside of implementing some custom string handling (wich could be handled relatively easily with a collection) I don't think there is anything we could do. It looks like this is how Guzzle natively handle special characters inside of the query option as well.

[adamwathan]

I've tried a bit of experimentation here and from what I can tell, PHP seems to convert periods in query string parameters to underscores when it receives them, which makes me wonder if this is supposed to get escaped or something instead.

This is what I get when dumping the raw $_GET variable:

This makes me think it'll be hard for us to test.

Right now the way Zttp works, we extract the query string from the URL and merge it with the query data passed through as a request option, then send that to Guzzle through it's query option. Guzzle doesn't support sending the query string through both the URL and the request options; the request options always win. That behavior is annoying and I'd rather merge them which is what Zttp tries to do.

Since parse_str seems to fuck up periods, I think we either need to:

a. Write a custom query string parsing function, which sounds like hell because I have no idea what all of the edge cases and spec rules are here.

b. Instead of merging query string parameters into the array version of the query string, do it the other way around and stick the query parameters that were passed via array into the URL. This is probably harder to get right than it sounds too.

[adamwathan]

Also to test this, we can't rely on the query string PHP parses out in the Lumen server because PHP will replace dots with underscores.

Instead we'll probably need to return the requests URL string back to the client for the client to inspect so we can check that it contains the expected query string before PHP mangles the periods into underscores. All gross shit but whatever.

[sixlive]

I've got a few ideas, I'll keep playing with it.

[irazasyed]

Sorry for bumping an old thread but just hit a similar issue with the ported version of this library in Laravel. Were you guys able to figure this out?

Please ref my issue ticket and share your thoughts if possible. laravel/ideas#2137

This is also similar to the #77 issue in this lib.