From a284bd88ff89f9dd2633fc83f144553ce5224faa Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 13 Jan 2026 14:20:23 -0500 Subject: [PATCH 1/4] remove redundant checks --- packages/client/src/clients/guide/client.ts | 5 ----- 1 file changed, 5 deletions(-) diff --git a/packages/client/src/clients/guide/client.ts b/packages/client/src/clients/guide/client.ts index 9c089521..4fa3e4a1 100644 --- a/packages/client/src/clients/guide/client.ts +++ b/packages/client/src/clients/guide/client.ts @@ -952,17 +952,12 @@ export class KnockGuideClient { ...rest, message: { ...message }, markAsSeen() { - // Send a seen event if it has not been previously seen. - if (this.message.seen_at) return; return self.markAsSeen(localGuide, this); }, markAsInteracted({ metadata }: { metadata?: GenericData } = {}) { - // Always send an interaction event through. return self.markAsInteracted(localGuide, this, metadata); }, markAsArchived() { - // Send an archived event if it has not been previously archived. - if (this.message.archived_at) return; return self.markAsArchived(localGuide, this); }, }; From 61c89caab9f9a514eb08b388aa87f7bd848e55e1 Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 13 Jan 2026 14:23:32 -0500 Subject: [PATCH 2/4] upgrade node.js to v24 --- .tool-versions | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.tool-versions b/.tool-versions index a3955f43..e871cd69 100644 --- a/.tool-versions +++ b/.tool-versions @@ -1,2 +1,2 @@ -nodejs 22.17.0 +nodejs 24.12.0 yarn 1.22.22 diff --git a/package.json b/package.json index 87252c38..6c08dae8 100644 --- a/package.json +++ b/package.json @@ -52,6 +52,6 @@ "vitest": "^3.1.1" }, "engines": { - "node": "22.17.0" + "node": ">=24.10.0" } } From 850c061d5dfc5c722cd63f3766204789be2d79e9 Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 13 Jan 2026 15:54:17 -0500 Subject: [PATCH 3/4] fix KnockGuideStep type definition --- packages/client/src/clients/guide/types.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/client/src/clients/guide/types.ts b/packages/client/src/clients/guide/types.ts index ce4fdeec..f7112713 100644 --- a/packages/client/src/clients/guide/types.ts +++ b/packages/client/src/clients/guide/types.ts @@ -166,9 +166,11 @@ export type GuideSocketEvent = export interface KnockGuideStep extends GuideStepData { - markAsSeen: () => void; - markAsInteracted: (params?: { metadata?: GenericData }) => void; - markAsArchived: () => void; + markAsSeen: () => Promise | undefined>; + markAsInteracted: (params?: { + metadata?: GenericData; + }) => Promise | undefined>; + markAsArchived: () => Promise | undefined>; } export interface KnockGuideActivationUrlPattern From 37363d1917333a164a4021c54c497202eb3983c8 Mon Sep 17 00:00:00 2001 From: Thomas Date: Tue, 13 Jan 2026 17:08:33 -0500 Subject: [PATCH 4/4] changeset --- .changeset/yellow-worlds-smile.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/yellow-worlds-smile.md diff --git a/.changeset/yellow-worlds-smile.md b/.changeset/yellow-worlds-smile.md new file mode 100644 index 00000000..9c90cf14 --- /dev/null +++ b/.changeset/yellow-worlds-smile.md @@ -0,0 +1,5 @@ +--- +"@knocklabs/client": patch +--- + +[guides] fix: KnockGuideStep type definition to return a promise from async methods