-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
@xanarin pointed out that Git allows a tag and a branch to have the same name. So the fix in #16 introduces a potential ambiguity, by no longer allowing tags/v1.2.3.
The problem is that the GitLab list project pipelines API just says ref, and I've proven that you cannot pass tags/foo:
>>> p.pipelines.list(ref='v8.4.8-1')
[<ProjectPipeline id:20692>, <ProjectPipeline id:20685>, <ProjectPipeline id:20639>, <ProjectPipeline id:20638>, <ProjectPipeline id:20478>]
>>> p.pipelines.list(ref='tags/v8.4.8-1')
[]
The API does however provide scope:
| Attribute | Type | Required | Description |
|---|---|---|---|
scope |
string | no | The scope of pipelines, one of: running, pending, finished, branches, tags |
So perhaps we could look at the ref to see if tags/ is present, and if so, strip it, and then pass scope=tags.
Metadata
Metadata
Assignees
Labels
No labels