CSV done state

[arugu1a]

As discussed in yesterday’s Zoom meeting, the CSV log currently only records a train as done if an action for the train is issued after it reaches its destination. After looking into it further, I found a rather simple fix. I suggest adding the following code snippet after the main while loop to log the final status of all trains at the last time step:

for i, agent in enumerate(env.agents):
        if agent.position is not None:
            position = agent.position
        else:
            position = "off map"
        log.add(f'{i};{timestep};{position};{dir_map[agent.direction]};{dir_map[env.agents[i].direction]};{state_map[env.agents[i].state]};\n')

Here is an example on how the bottom of the CSV looks after the change:

.
.
.
7;182;(79, 56);e;moving;move_forward
0;183;(64, 78);n;moving;move_forward
7;183;(79, 57);e;moving;move_forward
0;184;off map;n;n;done;
1;184;(77, 53);n;n;stopped;
2;184;off map;s;s;done;
3;184;off map;w;w;done;
4;184;(77, 52);e;e;stopped;
5;184;off map;w;w;done;
6;184;off map;n;n;done;
7;184;off map;e;e;done;

This also confirms that no extra action is needed on the train’s end cell to reach the done state. Also note that the last recorded time step before the change in this example was 183, meaning the actual final time step was cut off causing the last done state to never be displayed, even with an extra action.
Hope this helps! : )

[FeignDeath]

I think more expressive output of the solve.py would be nice. I just want to throw this here:
One can use:

success = all(info["state"][i] == TrainState.DONE for i in info["state"])

to determine whether all trains succesfully reached their goals (and also split it to get the separate info).

As opposed to:

done['__all__']

which also holds, when the instance reached it's limit. Just a note if someone wants to use it.

[arugu1a]

Nice addition, I didn't know that about done['__all__'] and I definitely the support the idea of a more expressive output. Something like FAILURE: 4/7 Trains reached their target would be a great improvment.
That said, my proposed solution should still work as intended, right? I think both approaches would complement each other well:

Terminal output: Summary

CSV: Detailed information

[FeignDeath]

I agree.