From 9ff6efe2e9607e584d0fed285a6ed0ed87dca300 Mon Sep 17 00:00:00 2001 From: Adam Coulombe Date: Wed, 3 Feb 2021 22:23:19 -0500 Subject: [PATCH 1/5] add quotes around default key path --- bin/http-server | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/http-server b/bin/http-server index cd879ec06..37881f34b 100755 --- a/bin/http-server +++ b/bin/http-server @@ -117,7 +117,7 @@ function listen(port) { log('Generating and using default cert and key files in: '.yellow + __dirname.cyan); exec('openssl genrsa -out ' + defaultKeyPath + ' 4096', function(err) { handleCreatingCertError(err); - err || exec('openssl req -new -key ' + defaultKeyPath + ' -out ' + defaultCSRPath + + err || exec('openssl req -new -key "' + defaultKeyPath + '" -out ' + defaultCSRPath + ' -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' + '/OU=dev/CN=localhost/emailAddress=test@test.com"', function(err) { From a81a7bad981a0347f33b5135353bd79e09eabb67 Mon Sep 17 00:00:00 2001 From: Adam Coulombe Date: Wed, 3 Feb 2021 22:35:21 -0500 Subject: [PATCH 2/5] add quotes to key paths --- bin/http-server | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/http-server b/bin/http-server index 37881f34b..60820f6d1 100755 --- a/bin/http-server +++ b/bin/http-server @@ -115,14 +115,14 @@ function listen(port) { if (!fs.existsSync(defaultCertPath)) { log('Generating and using default cert and key files in: '.yellow + __dirname.cyan); - exec('openssl genrsa -out ' + defaultKeyPath + ' 4096', function(err) { + exec('openssl genrsa -out "' + defaultKeyPath + '" 4096', function(err) { handleCreatingCertError(err); err || exec('openssl req -new -key "' + defaultKeyPath + '" -out ' + defaultCSRPath + ' -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' + '/OU=dev/CN=localhost/emailAddress=test@test.com"', function(err) { handleCreatingCertError(err); - err || exec('openssl x509 -req -days 1000 -in ' + defaultCSRPath + ' -signkey ' + + err || exec('openssl x509 -req -days 1000 -in "' + defaultCSRPath + '" -signkey ' + defaultKeyPath + ' -out ' + defaultCertPath, function(err) { handleCreatingCertError(err); From ad423fba297ff37cb055552a43aef6df08ffb392 Mon Sep 17 00:00:00 2001 From: Adam Coulombe Date: Wed, 3 Feb 2021 22:36:37 -0500 Subject: [PATCH 3/5] add quote around path --- bin/http-server | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/http-server b/bin/http-server index 60820f6d1..f9417d4ef 100755 --- a/bin/http-server +++ b/bin/http-server @@ -117,8 +117,8 @@ function listen(port) { log('Generating and using default cert and key files in: '.yellow + __dirname.cyan); exec('openssl genrsa -out "' + defaultKeyPath + '" 4096', function(err) { handleCreatingCertError(err); - err || exec('openssl req -new -key "' + defaultKeyPath + '" -out ' + defaultCSRPath + - ' -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' + + err || exec('openssl req -new -key "' + defaultKeyPath + '" -out "' + defaultCSRPath + + '" -subj "/C=US/ST=California/L=San Francisco/O=Local-Company' + '/OU=dev/CN=localhost/emailAddress=test@test.com"', function(err) { handleCreatingCertError(err); From 07ccc38181e5234cb1e424654f43d6863a0f4859 Mon Sep 17 00:00:00 2001 From: Adam Coulombe Date: Wed, 3 Feb 2021 22:37:58 -0500 Subject: [PATCH 4/5] add quote around path --- bin/http-server | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/http-server b/bin/http-server index f9417d4ef..660d519d4 100755 --- a/bin/http-server +++ b/bin/http-server @@ -123,7 +123,7 @@ function listen(port) { handleCreatingCertError(err); err || exec('openssl x509 -req -days 1000 -in "' + defaultCSRPath + '" -signkey ' + - defaultKeyPath + ' -out ' + defaultCertPath, function(err) { + defaultKeyPath + ' -out "' + defaultCertPath + '"', function(err) { handleCreatingCertError(err); err || createServer(); From 1a56808f2d70a7c1c4632da245fb5369d06d905e Mon Sep 17 00:00:00 2001 From: Adam Coulombe Date: Wed, 3 Feb 2021 22:39:35 -0500 Subject: [PATCH 5/5] add quotes around path --- bin/http-server | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/http-server b/bin/http-server index 660d519d4..ed748209c 100755 --- a/bin/http-server +++ b/bin/http-server @@ -122,8 +122,8 @@ function listen(port) { '/OU=dev/CN=localhost/emailAddress=test@test.com"', function(err) { handleCreatingCertError(err); - err || exec('openssl x509 -req -days 1000 -in "' + defaultCSRPath + '" -signkey ' + - defaultKeyPath + ' -out "' + defaultCertPath + '"', function(err) { + err || exec('openssl x509 -req -days 1000 -in "' + defaultCSRPath + '" -signkey "' + + defaultKeyPath + '" -out "' + defaultCertPath + '"', function(err) { handleCreatingCertError(err); err || createServer();