-
Notifications
You must be signed in to change notification settings - Fork 2
Description
This ticket is to update the commit hash of modelica-json to the latest available in the master branch of https://github.com/lbl-srg/modelica-json.
This is needed to include the fixes from lbl-srg/modelica-json#281, namely
- correct and recursive parsing of logical expressions
- handling of package.order
TODO:
-
Add support not operator in expression evaluation #462:
- Parser updated
- Check if interpreter works correctly with
{ operator: "!", operand: [...] }: switch clause added, test updated
-
Solve rdflib (peer dep from modelica-json) not compiling with tsc: now excluded with
skipLibCheck -
Refactor for updated schema modelica-json#245:
class_definitionis nowstored_class_definitions -
Refactor for change in
arithmetic_expressionsschema
⚠️ What is called herearithmetic_expressionsdiffers from the grammar:arithmetic-expression : [ add-operator ] term { add-operator term }. Instead modelica-json seems to usesimple_expressionas an equivalent for the grammararithmetic-expression... but not always: see next bullet point.Old schema
{ "arithmetic_expressions": [ { "name": "fanSupDra.typ" }, { "name": "Buildings.Templates.Components.Types.Fan.None" } ], "relation_operator": "<>" }New schema
{ "arithmetic_expressions": [ "fanSupDra.typ", "Buildings.Templates.Components.Types.Fan.None" ], "relation_operator": "<>" } -
Expansion of
simple_expression
❌ Conflict with Ag/478 remove check #479Old schema
"simple_expression": "(0.787 +0.764*Modelica.Math.log(-TDewPoiK/Modelica.Constants.T_zero))*(1 +0.0224*nOpa10 -0.0035*(nOpa10^2) +0.00028*(nOpa10^3))"
New schema