Skip to content

sundialsJac does not consistently check for null dstate_dt #52

@mcneish1

Description

@mcneish1

In griddyn/solvers/sundialsInterface.cpp, sundialsJac is allowed to be passed a null dstate_dt. It acknowledges this here and here.

However,

https://github.com/LLNL/GridDyn/blob/cf850abcc921f9f1bfea917ffc03a966d64c0a6a/src/griddyn/solvers/sundialsInterface.cpp#L462

and

https://github.com/LLNL/GridDyn/blob/cf850abcc921f9f1bfea917ffc03a966d64c0a6a/src/griddyn/solvers/sundialsInterface.cpp#L471

do not check for this, and can segfault. These should have the same nullptr check as above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions