From ce42c7069b3e7e20fd349efd1a6560ef6f6cf829 Mon Sep 17 00:00:00 2001 From: cOng Date: Sun, 23 Feb 2025 15:57:37 +0800 Subject: [PATCH 1/2] fix: type mis-match of Context and model list --- fastchat/serve/gradio_web_server.py | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/fastchat/serve/gradio_web_server.py b/fastchat/serve/gradio_web_server.py index 8941c6ecb..d0752f37c 100644 --- a/fastchat/serve/gradio_web_server.py +++ b/fastchat/serve/gradio_web_server.py @@ -252,20 +252,15 @@ def get_model_list(controller_url, register_api_endpoint_file, vision_arena): return visible_models, models -def load_demo_single(context: Context, query_params): - # default to text models - models = context.text_models - +def load_demo_single(models, query_params): selected_model = models[0] if len(models) > 0 else "" if "model" in query_params: model = query_params["model"] if model in models: selected_model = model - all_models = context.models - dropdown_update = gr.Dropdown( - choices=all_models, value=selected_model, visible=True + choices=models, value=selected_model, visible=True ) state = None return [state, dropdown_update] From d4c3b0cd184567d0efb711f352343b31cd695837 Mon Sep 17 00:00:00 2001 From: cOng Date: Sun, 23 Feb 2025 16:54:28 +0800 Subject: [PATCH 2/2] reformat by pylint --- fastchat/serve/gradio_web_server.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fastchat/serve/gradio_web_server.py b/fastchat/serve/gradio_web_server.py index d0752f37c..3963a3c85 100644 --- a/fastchat/serve/gradio_web_server.py +++ b/fastchat/serve/gradio_web_server.py @@ -259,9 +259,7 @@ def load_demo_single(models, query_params): if model in models: selected_model = model - dropdown_update = gr.Dropdown( - choices=models, value=selected_model, visible=True - ) + dropdown_update = gr.Dropdown(choices=models, value=selected_model, visible=True) state = None return [state, dropdown_update]