From e9c68e5b03575e4bc358af6e21f9853f580ace69 Mon Sep 17 00:00:00 2001 From: yonatanp Date: Wed, 1 May 2013 12:28:44 +0300 Subject: [PATCH] Adhering to some standard python conventions - changed classes to new-style (derive from object) - class names start with a Capital letter --- loggr.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/loggr.py b/loggr.py index 8fe6e27..db3fd7b 100644 --- a/loggr.py +++ b/loggr.py @@ -1,16 +1,16 @@ import urllib import urllib2 -class Config: +class Config(object): logKey = "" apiKey = "" -class dataType: +class DataType(object): html = 0 plaintext = 1 json = 2 -class Event: +class Event(object): text = '' link = '' source = '' @@ -18,15 +18,15 @@ class Event: tags = '' value = '' data = '' - dataType = dataType.plaintext + dataType = DataType.plaintext geo = '' -class Events: +class Events(object): @staticmethod def Create(): return FluentEvent() -class Users: +class Users(object): @staticmethod def TrackUser(username, email, page): values = {} @@ -41,7 +41,7 @@ def TrackUser(username, email, page): req = urllib2.Request(url, data) response = urllib2.urlopen(req) -class FluentEvent: +class FluentEvent(object): e = Event() def Text(self, t): self.e.text = t @@ -88,9 +88,9 @@ def Post(self): if self.e.value: values['value'] = self.e.value if self.e.data: - if self.e.dataType == dataType.html: + if self.e.dataType == DataType.html: values['data'] = '@html\n' + str(self.e.data) - elif self.e.dataType == dataType.json: + elif self.e.dataType == DataType.json: values['data'] = '@json\n' + str(self.e.data) else: values['data'] = str(self.e.data) @@ -100,4 +100,4 @@ def Post(self): data = urllib.urlencode(values) req = urllib2.Request(url, data) response = urllib2.urlopen(req) - \ No newline at end of file +