From a8aa86352aa8bbdc21d1914fd0ccc6b457a9ea8a Mon Sep 17 00:00:00 2001 From: Jeremy Date: Fri, 16 Jan 2026 16:22:44 -0800 Subject: [PATCH] Updating all the versions. Setting new min version to 1.16 and ensure 1.19 works --- .github/workflows/ci.yml | 7 ++++--- .github/workflows/docs.yml | 4 ++-- shard.yml | 2 +- spec/lucky/format_edge_cases_spec.cr | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f08400e1d..62889e8ad 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest continue-on-error: false steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: crystal-lang/install-crystal@v1 with: crystal: latest @@ -29,11 +29,12 @@ jobs: matrix: os: - ubuntu-latest + - macos-latest - windows-latest shard_file: - shard.yml crystal_version: - - 1.15.1 + - 1.16.3 - latest experimental: - false @@ -49,7 +50,7 @@ jobs: runs-on: ${{ matrix.os }} continue-on-error: ${{ matrix.experimental }} steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 - uses: crystal-lang/install-crystal@v1 with: crystal: ${{matrix.crystal_version}} diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index e21560b3d..d1e3b12bf 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -2,13 +2,13 @@ name: Deploy docs on: push: - branches: [ main ] + branches: [main] jobs: deploy: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6 with: persist-credentials: false - uses: crystal-lang/install-crystal@v1 diff --git a/shard.yml b/shard.yml index f2076555f..4969a95ac 100644 --- a/shard.yml +++ b/shard.yml @@ -1,7 +1,7 @@ name: lucky version: 1.4.0 -crystal: ">= 1.15.1" +crystal: ">= 1.16.3" authors: - Paul Smith diff --git a/spec/lucky/format_edge_cases_spec.cr b/spec/lucky/format_edge_cases_spec.cr index 0a6587fa1..c4b824741 100644 --- a/spec/lucky/format_edge_cases_spec.cr +++ b/spec/lucky/format_edge_cases_spec.cr @@ -245,9 +245,9 @@ describe "Format Detection Edge Cases" do long_path = "/very/long/path/" + ("segment/" * 1000) + "file.json" # Should still extract format efficiently - start_time = Time.monotonic + start_time = {% if compare_versions(Crystal::VERSION, "1.19.0") < 0 %}Time.monotonic{% else %}Time.instant{% end %} format = Lucky::MimeType.extract_format_from_path(long_path) - end_time = Time.monotonic + end_time = {% if compare_versions(Crystal::VERSION, "1.19.0") < 0 %}Time.monotonic{% else %}Time.instant{% end %} format.should eq Lucky::Format::Json (end_time - start_time).should be < 0.1.seconds # Should be very fast