Building react-native-spotify 1.2.11 with 0.61.1

[patrice4github]

I'm sorry, this is more a question than an issue.

Thanks for your solid work on this library it is very useful to me. I know Spotify is going to the remote version of the API, but in the mean time, I'd like build it locally to investigate an issue.

It stopped working properly after I upgraded to RN 0.61.1. I can no longer login. The web view appears a bit, and closes right away.

I'm trying to build it in the mean time to diagnose this but I can't. Can I ask about your setup?

I have clone ancillary modules at the same level:

I'm looking at the project includes

Were you able to test 1.2.11 on IOS yesterday? I can't where <SpotifyAudioPlayback/SpotifyAudioPlayback.h> is going to be found from these locations.

Any help will be appreciated.

[lufinkey]

So I've had this issue too, but it only seemed to happen on the iPhone 8 simulator on iOS 13. The iPhone 11 simulators seemed to work fine. It seems like a bug in iOS, but I'm not entirely sure at this point.

Can you let me know if you see something like this in your logs?

[ProcessSuspension] 0x1195f67b0 - ProcessAssertion::processAssertionWasInvalidated()

As for the include issue, not sure what's up with that. Might have something to do with the fact that I updated the submodule repos to point at my forked Spotify SDK repos. I'll take a look at that.

[lufinkey]

Can you also see if passing {showDialog:true} to your login function fixes the issue?

[patrice4github]

"{showDialog:true}" doesn't help. The dialog still opens up but it's only a flicker. It closes right away...

…

On Wed, Oct 2, 2019 at 10:59 AM Luis Finke ***@***.***> wrote: Can you also see if passing {showDialog:true} to your login function fixes the issue? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#144?email_source=notifications&email_token=AANFW7RWMZIS5OJCIZQAPWTQMSZMRA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFB4YA#issuecomment-537534048>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANFW7SJMCBJ3V3P3KQNSRDQMSZMRANCNFSM4I4XBTCA> .

[lufinkey]

So the framework should be included directly. Can you make sure that node_modules/rn-spotify-sdk/ios/external/SpotifySDK has the frameworks inside it?

[lufinkey]

You shouldn't need to clone the frameworks yourself

[lufinkey]

Can you also see if the project works when you use an older version of the module? Can you force it to use 1.2.10?

[patrice4github]

[ProcessSuspension] 0x1195f67b0 - ProcessAssertion:: processAssertionWasInvalidated() Yes I do.

…

On Wed, Oct 2, 2019 at 11:04 AM Luis Finke ***@***.***> wrote: You shouldn't need to clone the frameworks yourself — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#144?email_source=notifications&email_token=AANFW7VWG4ANH6VGTBF5YMDQMS2BDA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCQ6I#issuecomment-537536633>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANFW7V2ZELACJXYSQFM7FDQMS2BDANCNFSM4I4XBTCA> .

[lufinkey]

Cool so that confirms we have the same bug with the web view disappearing

[lufinkey]

Please try with 1.2.10 and let me know if you still encounter the bug

[patrice4github]

Yes it has been working for a few weeks: 0.60.5 : 1.2.10 Yes 0.61.1 : 1.2.10 No 0.61.1 : 1.2.11 No Unfortunately, I upgraded my box to xCode 11 inadvertently and 0.60.5 stopped working with a weird error. I seem stuck with 0.61.1.

…

On Wed, Oct 2, 2019 at 11:07 AM Luis Finke ***@***.***> wrote: Can you also see if the project works when you use an older version of the module? Can you force it to use 1.2.10? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#144?email_source=notifications&email_token=AANFW7RZTTCZCS5CBIH6V5LQMS2KRA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCZWQ#issuecomment-537537754>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANFW7TW3OXFEDVVXQ4IWILQMS2KRANCNFSM4I4XBTCA> .

[patrice4github]

By Yes, I meant it was working for this version pair. "So the framework should be included directly. Can you make sure that node_modules/rn-spotify-sdk/ios/external/SpotifySDK has the frameworks inside it?" You mean, I'd have to npm install rn-spotify-sdk to build the actual sdk it self? Or it's just to get the framework? On Wed, Oct 2, 2019 at 11:10 AM Patrice Gagnon <patrice@patricegagnon.com> wrote:

…

Yes it has been working for a few weeks: 0.60.5 : 1.2.10 Yes 0.61.1 : 1.2.10 No 0.61.1 : 1.2.11 No Unfortunately, I upgraded my box to xCode 11 inadvertently and 0.60.5 stopped working with a weird error. I seem stuck with 0.61.1. On Wed, Oct 2, 2019 at 11:07 AM Luis Finke ***@***.***> wrote: > Can you also see if the project works when you use an older version of > the module? Can you force it to use 1.2.10? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#144?email_source=notifications&email_token=AANFW7RZTTCZCS5CBIH6V5LQMS2KRA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCZWQ#issuecomment-537537754>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AANFW7TW3OXFEDVVXQ4IWILQMS2KRANCNFSM4I4XBTCA> > . >

[patrice4github]

Still no luck going back 1.2.10, as I was yesterday. Same behavior, really looks like a 0.61.1 related issue. On Wed, Oct 2, 2019 at 11:17 AM Patrice Gagnon <patrice@patricegagnon.com> wrote:

…

By Yes, I meant it was working for this version pair. "So the framework should be included directly. Can you make sure that node_modules/rn-spotify-sdk/ios/external/SpotifySDK has the frameworks inside it?" You mean, I'd have to npm install rn-spotify-sdk to build the actual sdk it self? Or it's just to get the framework? On Wed, Oct 2, 2019 at 11:10 AM Patrice Gagnon ***@***.***> wrote: > Yes it has been working for a few weeks: > > 0.60.5 : 1.2.10 Yes > 0.61.1 : 1.2.10 No > 0.61.1 : 1.2.11 No > > Unfortunately, I upgraded my box to xCode 11 inadvertently and 0.60.5 > stopped working with a weird error. I seem stuck with 0.61.1. > > > > On Wed, Oct 2, 2019 at 11:07 AM Luis Finke ***@***.***> > wrote: > >> Can you also see if the project works when you use an older version of >> the module? Can you force it to use 1.2.10? >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#144?email_source=notifications&email_token=AANFW7RZTTCZCS5CBIH6V5LQMS2KRA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCZWQ#issuecomment-537537754>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AANFW7TW3OXFEDVVXQ4IWILQMS2KRANCNFSM4I4XBTCA> >> . >> >

[lufinkey]

Yeah that's what I was worried about. I think it an iOS bug. The odd thing is I retested my other project on the simulator again and the bug seems to have gone away. Not sure what that means.

Also the Spotify streaming SDK frameworks should be included in the node module folder when you install it via npm install rn-spotify-sdk. You just need to add the framework search path

[patrice4github]

You lost me there. My framework search patch seems correct: [image: Screen Shot 2019-10-02 at 1.00.47 PM.png] I have an import not found, will the framework search path help? I don't see that you include node_module in your header search path, I'm still curious as to where this one resolves: [image: Screen Shot 2019-10-02 at 12.59.35 PM.png]

…

On Wed, Oct 2, 2019 at 12:53 PM Luis Finke ***@***.***> wrote: Yeah that's what I was worried about. I think it an iOS bug. The odd thing is I retested my other project on the simulator again and the bug seems to have gone away. Not sure what that means. Also the Spotify streaming SDK frameworks should be included in the node module folder when you install it via npm install rn-spotify-sdk. You just need to add the framework search path — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#144?email_source=notifications&email_token=AANFW7WXJZGVRB5C5OUST23QMTGZDA5CNFSM4I4XBTCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFOAXQ#issuecomment-537583710>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANFW7QVYSUJTT2DVOTOF5DQMTGZDANCNFSM4I4XBTCA> .

[lufinkey]

It's not a header search path. It's a framework search path. They're different. The README explains where you need to add it.