`/usr/bin/profiles show -type enrollment` not being throttled

[getvictor]

The code intent is to throttle access to profiles show -type enrollment command:

osquery-extension/tables/mdm/mdm.go

Line 202 in 5461c45

hasAlreadyChecked := hasCheckedCloudConfigInPast24Hours(CloudConfigTimerCheck)

However, this never happens because the file it checks is never created:

/private/var/db/ConfigurationProfiles/Settings/.cloudConfigTimerCheck

Also, the latest manpage states that the limit is 10 times per 23 hours, so the throttling can be reduced to <3 hours per request.

[grahamgilbert]

@getvictor So how should we measure this?

[getvictor]

If this isn't causing issues, maybe it is simplest to remove the code that pretends to throttle the access?

[grahamgilbert]

If the code isn't working, and someone queries this table more than 10 times in a 23 hour period, or calls profiles show 10 times elsewhere and then tries this table, it will fail.