feat: Add bfcache support

[rhoerr]

Mage-OS/Magento and this module would benefit from having backwards/forwards cache (bfcache) support added. We should do that.

Davide sent a PR in with #2 .
Oli/JaJuMa and Siteation.dev have also expressed interest in helping with the feature.

[JaJuMa]

@rhoerr Here is our PR as discussed #5

[gilbertococchi]

Great to see this PR opened, thanks for that!

Looking to see BFCache more available to Magento sites in the future!

[rhoerr]

#5 is processed. More to come in #2 pending discussion.

[GrimLink]

Hi @rhoerr, I have some concerns about the approach taken in PR #5, which was merged instead of #2.

The implementation in #5 uses certain Hyvä components (like ViewModels and the CSP helper) in ways that are inconsistent with their intended design.

I apologize for not having the time to provide this feedback here sooner.

I am btw happy that @JaJuMa implemented the BFCache using the cache control header, something we also tried with our version in the Siteation/magento2-pagespeed, instead solely working with a exclude list, as @JaJuMa did with there own module 👍

[JaJuMa]

@GrimLink

instead solely working with a exclude list, as @JaJuMa did with there own module 👍

What makes you think our module is "solely working with a exclude list" ???
Spoiler: Its not...

[rhoerr]

Let's stay constructive please. I think we all want the same outcomes here: a better Magento and internet (if we can).

Thank you both for your contributions

Discussion is ongoing in #2 about the VCL aspects. I also saw you submitted other feedback @GrimLink; thanks for that.

So far the bfcache feature (and all recent changes) is still in development as far as I'm concerned. I want to resolve discussions and give time to finalize the approach before we mark it stable and release. I expect that to happen in 2-3 weeks (in time for the next Mage-OS release) unless things move quickly.

Meanwhile, I tagged 2.0.0-alpha2 yesterday for anyone that wants to try it in its current state.

[JaJuMa]

@rhoerr Just to clarify my earlier comment: it was not meant to come across as unconstructive.

I’m genuinely curious where such assumptions or claims that are not accurate originate.
My intention in pointing this out was to understand the source and reasoning behind them, since unclear or unsupported claims aren’t very helpful toward our shared goal.

Thanks for the discussion, and I appreciate everyone’s input here. 🙏

[GrimLink]

@JaJuMa, to provide more context for my last comment: I've used your module before and remembered a version that had an exclude list for the BFCache. I wasn't sure if that functionality was updated.

There was no negative feedback intended. I'm happy with how the you added BFCache here.

[JaJuMa]

@GrimLink Just to clarify:

The statement about “solely working with an exclude list” was true only for the very first release (v1.0.0 - released 09.03.2023).
Starting with v1.0.1 (released 18.04.2023), the implementation was changed to use Magento’s FPC cacheable/not-cacheable logic, with optional flexibility to exclude specific URLs.

So the description given here no longer applies to the module as it has existed for the past 2.5 years.

It’s generally not very helpful to judge software based on such an old version.
The current implementation is quite different and was the base for the contribution here, and that’s what our discussion should focus on.

[GrimLink]

@JaJuMa, my apologies then.
It's a shame this part of my comment got all the attention instead of the positive feedback I gave 😞.

[JaJuMa]

@GrimLink Totally understood, and nothing personal at all.

You’re right - unfortunately, it’s often the negative parts of a comment that catch attention and stick.
Guess that's why I’m a bit sensitive to that, especially with regards to this module, given some past discussions and context outside this thread particularly regarding this module.

Thanks for clarifying, and I really do appreciate your positive feedback as well! 🙏

[rhoerr]

Primary bfcache support added in #5, with revisions happening in #15 and #16. Should be wrapped as soon as those are finalized and approved.

[rhoerr]

#15 and #16 are merged. I've tagged 2.0.0-rc1 with all of the changes to date. Final release will be in the coming days.

Thank you all