From 33fb131c05117cc7817717030c53889b4f87fb16 Mon Sep 17 00:00:00 2001 From: Ryo Anazawa Date: Sun, 31 Mar 2013 19:11:32 +0900 Subject: [PATCH 1/3] more tests for header_props() --- t/header_props.t | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/t/header_props.t b/t/header_props.t index 1561176..545b648 100644 --- a/t/header_props.t +++ b/t/header_props.t @@ -92,3 +92,14 @@ $ENV{CGI_APP_RETURN_ONLY} = 1; } +{ + my $app = CGI::Application->new; + + $app->header_props( type => 'banana/ripe' ); + + like( + $app->run, + qr{Content-type: banana/ripe}i, + "an initial dash of prop. name can be omitted", + ); +} From a528d7a24a4fcacd60856819a08b54c089ba5254 Mon Sep 17 00:00:00 2001 From: Ryo Anazawa Date: Sun, 31 Mar 2013 19:24:21 +0900 Subject: [PATCH 2/3] pass hashref to CGI#header explicitly --- lib/CGI/Application.pm | 8 ++++---- t/header_props.t | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/CGI/Application.pm b/lib/CGI/Application.pm index c64e1f1..b7dec16 100644 --- a/lib/CGI/Application.pm +++ b/lib/CGI/Application.pm @@ -657,8 +657,8 @@ sub _send_headers { my $type = $self->header_type; return - $type eq 'redirect' ? $q->redirect( $self->header_props ) - : $type eq 'header' ? $q->header ( $self->header_props ) + $type eq 'redirect' ? $q->redirect({ $self->header_props }) + : $type eq 'header' ? $q->header ({ $self->header_props }) : $type eq 'none' ? '' : croak "Invalid header_type '$type'" } @@ -670,8 +670,8 @@ sub _send_psgi_headers { my $type = $self->header_type; return - $type eq 'redirect' ? $q->psgi_redirect( $self->header_props ) - : $type eq 'header' ? $q->psgi_header ( $self->header_props ) + $type eq 'redirect' ? $q->psgi_redirect({ $self->header_props }) + : $type eq 'header' ? $q->psgi_header ({ $self->header_props }) : $type eq 'none' ? '' : croak "Invalid header_type '$type'" diff --git a/t/header_props.t b/t/header_props.t index 545b648..32940d4 100644 --- a/t/header_props.t +++ b/t/header_props.t @@ -1,6 +1,6 @@ use strict; -use Test::More tests => 9; +use Test::More tests => 10; BEGIN{use_ok('CGI::Application');} From 46f25d9b13796c00bc817523d89d9365bc7f0d7b Mon Sep 17 00:00:00 2001 From: Ryo Anazawa Date: Sun, 31 Mar 2013 19:34:03 +0900 Subject: [PATCH 3/3] no need to call header_props() --- lib/CGI/Application.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/CGI/Application.pm b/lib/CGI/Application.pm index b7dec16..a2cea9f 100644 --- a/lib/CGI/Application.pm +++ b/lib/CGI/Application.pm @@ -657,8 +657,8 @@ sub _send_headers { my $type = $self->header_type; return - $type eq 'redirect' ? $q->redirect({ $self->header_props }) - : $type eq 'header' ? $q->header ({ $self->header_props }) + $type eq 'redirect' ? $q->redirect( $self->{__HEADER_PROPS} ) + : $type eq 'header' ? $q->header ( $self->{__HEADER_PROPS} ) : $type eq 'none' ? '' : croak "Invalid header_type '$type'" } @@ -670,8 +670,8 @@ sub _send_psgi_headers { my $type = $self->header_type; return - $type eq 'redirect' ? $q->psgi_redirect({ $self->header_props }) - : $type eq 'header' ? $q->psgi_header ({ $self->header_props }) + $type eq 'redirect' ? $q->psgi_redirect( $self->{__HEADER_PROPS} ) + : $type eq 'header' ? $q->psgi_header ( $self->{__HEADER_PROPS} ) : $type eq 'none' ? '' : croak "Invalid header_type '$type'"