From bf95809b1b18dae562b595fa7dd9404df8468035 Mon Sep 17 00:00:00 2001 From: Davide Oberto Date: Wed, 17 Dec 2025 16:16:34 +0100 Subject: [PATCH 1/2] Fixed CylinderShaft initialization when optional arguments given --- bladex/cylinder_shaft.py | 4 ++++ bladex/propeller.py | 5 +++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/bladex/cylinder_shaft.py b/bladex/cylinder_shaft.py index f424366..c99732c 100644 --- a/bladex/cylinder_shaft.py +++ b/bladex/cylinder_shaft.py @@ -22,9 +22,13 @@ def __init__(self, radius=1.0, height=1.0, orientation=None, origin=None): if orientation is None: self.orientation = [1.0, 0.0, 0.0] # default orientation along X + else: + self.orientation = orientation if origin is None: self.origin = [0.0, 0.0, 0.0] # default origin at (0,0,0) + else: + self.origin = origin def generate_solid(self): """ diff --git a/bladex/propeller.py b/bladex/propeller.py index bab0b03..337fbc0 100644 --- a/bladex/propeller.py +++ b/bladex/propeller.py @@ -23,10 +23,11 @@ class Propeller(object): :cvar OCC.Core.TopoDS.TopoDS_Shell sewed_full_body: propeller with shaft shell """ - def __init__(self, shaft, blade, n_blades): + def __init__(self, shaft, blade, n_blades, reflect=True): self.shaft_solid = shaft.generate_solid() - blade.apply_transformations(reflect=True) + if reflect: + blade.apply_transformations(reflect=True) blade_solid = blade.generate_solid( max_deg=2, display=False, errors=None ) From 8de0c5de70ff175ed136f9c3db71ec8f3803c6e2 Mon Sep 17 00:00:00 2001 From: Davide Oberto Date: Wed, 17 Dec 2025 18:55:04 +0100 Subject: [PATCH 2/2] Reverted propeller.py file --- bladex/propeller.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/bladex/propeller.py b/bladex/propeller.py index 337fbc0..bab0b03 100644 --- a/bladex/propeller.py +++ b/bladex/propeller.py @@ -23,11 +23,10 @@ class Propeller(object): :cvar OCC.Core.TopoDS.TopoDS_Shell sewed_full_body: propeller with shaft shell """ - def __init__(self, shaft, blade, n_blades, reflect=True): + def __init__(self, shaft, blade, n_blades): self.shaft_solid = shaft.generate_solid() - if reflect: - blade.apply_transformations(reflect=True) + blade.apply_transformations(reflect=True) blade_solid = blade.generate_solid( max_deg=2, display=False, errors=None )