From 646bdfec28e7e84a1e83f7e15b44f6911d73fcca Mon Sep 17 00:00:00 2001
From: ErrorWizard <78498955+ErrorWizard@users.noreply.github.com>
Date: Wed, 3 Feb 2021 09:33:33 -0800
Subject: [PATCH] add error reporting

---
 server/server.go | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/server/server.go b/server/server.go
index 23e1810..7003038 100644
--- a/server/server.go
+++ b/server/server.go
@@ -4,6 +4,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"log"
 	"math"
 	"net/http"
 	"net/url"
@@ -139,6 +140,7 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 			must(json.NewEncoder(w).Encode(batch.ErrorResponse{
 				Message: err.Error(),
 			}))
+			log.Println("authorization error:", err)
 			return
 		}
 	}
@@ -151,6 +153,7 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 			Message: "could not parse request",
 			DocURL:  "https://github.com/git-lfs/git-lfs/blob/v2.12.0/docs/api/batch.md#requests",
 		}))
+		log.Println("parse error:", "could not parse request")
 		return
 	}
 
@@ -168,6 +171,7 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 				Code:    422,
 				Message: "oid must be a SHA-256 hash in lower case hexadecimal",
 			}
+			log.Println("invalid oid:", "oid must be a SHA-256 hash in lower case hexadecimal")
 			continue
 		}
 
@@ -178,16 +182,19 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 					Code:    404,
 					Message: err.Error(),
 				}
+				log.Println("object not found:", err)
 				continue
 			} else if in.Size != int(info.Size) {
 				out.Error = &batch.ObjectError{
 					Code:    422,
 					Message: "found object with wrong size",
 				}
+				log.Println("found object with wrong size")
 			}
 
 			href, err := s.client.PresignedGetObject(r.Context(), s.bucket, s.key(in.OID), s.ttl, nil)
 			if err != nil {
+				log.Println("PresignedGetObject failed:", err)
 				panic(err)
 			}
 
@@ -205,6 +212,7 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 						Code:    422,
 						Message: "existing object with wrong size",
 					}
+					log.Println("existing object with wrong size")
 				}
 				// already exists, omit actions
 				continue
@@ -215,6 +223,7 @@ func (s *server) handleBatch(w http.ResponseWriter, r *http.Request) {
 					Code:    422,
 					Message: "cannot upload objects larger than 5GB to S3 via LFS basic transfer adapter",
 				}
+				log.Println("object too large")
 				continue
 			}