Address PR review comments

- Move create_orchestration span into scheduleNewOrchestrationInstance()
  so SDK creates it automatically (bachuv feedback: span should not be
  in user code). TYPE_CREATE_ORCHESTRATION is now used by the client.
- Remove manual span creation from TracingPattern sample; simplify code
- Update all 4 screenshots with latest trace structure
- README span detail shows activity:GetWeather attributes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: torosent

client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java

@@ -9,6 +9,8 @@
 import com.microsoft.durabletask.implementation.protobuf.TaskHubSidecarServiceGrpc.*;
 
 import io.grpc.*;
+import io.opentelemetry.api.trace.Span;
+import io.opentelemetry.context.Scope;
 
 import javax.annotation.Nullable;
 import java.time.Duration;
@@ -135,14 +137,30 @@ public String scheduleNewOrchestrationInstance(
             builder.putAllTags(options.getTags());
         }
 
-        TraceContext traceContext = TracingHelper.getCurrentTraceContext();
-        if (traceContext != null) {
-            builder.setParentTraceContext(traceContext);
-        }
+        // Create a create_orchestration span (matching .NET SDK pattern)
+        Map<String, String> spanAttrs = new HashMap<>();
+        spanAttrs.put(TracingHelper.ATTR_TYPE, TracingHelper.TYPE_CREATE_ORCHESTRATION);
+        spanAttrs.put(TracingHelper.ATTR_TASK_NAME, orchestratorName);
+        spanAttrs.put(TracingHelper.ATTR_INSTANCE_ID, instanceId);
+        Span createSpan = TracingHelper.startSpan(
+                TracingHelper.TYPE_CREATE_ORCHESTRATION + ":" + orchestratorName,
+                null, null, spanAttrs);
+        Scope createScope = createSpan.makeCurrent();
 
-        CreateInstanceRequest request = builder.build();
-        CreateInstanceResponse response = this.sidecarClient.startInstance(request);
-        return response.getInstanceId();
+        try {
+            // Capture trace context from the create_orchestration span
+            TraceContext traceContext = TracingHelper.getCurrentTraceContext();
+            if (traceContext != null) {
+                builder.setParentTraceContext(traceContext);
+            }
+
+            CreateInstanceRequest request = builder.build();
+            CreateInstanceResponse response = this.sidecarClient.startInstance(request);
+            return response.getInstanceId();
+        } finally {
+            createScope.close();
+            createSpan.end();
+        }
     }
 
     @Override

samples/README.md

@@ -68,15 +68,15 @@ Full span hierarchy showing the fan-out/fan-in pattern with paired Client+Server
 
 ![Jaeger trace detail](images/jaeger-full-trace-detail.png)
 
-### Jaeger — Span Attributes (Timer)
+### Jaeger — Span Attributes
 
-Timer span showing attributes aligned with the .NET SDK schema:
-- `durabletask.type=timer`
-- `durabletask.task.name=FanOutFanIn`
-- `durabletask.fire_at=2026-03-03T21:13:15.142Z`
+Activity span showing attributes aligned with the .NET SDK schema:
+- `durabletask.type=activity`
+- `durabletask.task.name=GetWeather`
 - `durabletask.task.instance_id=<orchestrationId>`
+- `durabletask.task.task_id=1`
 - `otel.scope.name=Microsoft.DurableTask`
-- `span.kind=internal`
+- `span.kind=server`
 
 ![Jaeger span detail](images/jaeger-span-detail.png)
 

samples/images/dts-dashboard-completed.png

@@ -6,12 +6,6 @@
 import com.microsoft.durabletask.azuremanaged.DurableTaskSchedulerClientExtensions;
 import com.microsoft.durabletask.azuremanaged.DurableTaskSchedulerWorkerExtensions;
 
-import io.opentelemetry.api.GlobalOpenTelemetry;
-import io.opentelemetry.api.trace.Span;
-import io.opentelemetry.api.trace.StatusCode;
-import io.opentelemetry.api.trace.Tracer;
-import io.opentelemetry.context.Context;
-import io.opentelemetry.context.Scope;
 import io.opentelemetry.exporter.otlp.trace.OtlpGrpcSpanExporter;
 import io.opentelemetry.sdk.OpenTelemetrySdk;
 import io.opentelemetry.sdk.resources.Resource;
@@ -41,9 +35,6 @@
 final class TracingPattern {
     private static final Logger logger = Logger.getLogger(TracingPattern.class.getName());
 
-    // Shared parent context so activity spans become children of the orchestration span
-    private static volatile Context orchestrationContext;
-
     public static void main(String[] args) throws IOException, InterruptedException, TimeoutException {
         // Configure OpenTelemetry with OTLP exporter to Jaeger
         String otlpEndpoint = System.getenv("OTEL_EXPORTER_OTLP_ENDPOINT");
@@ -68,7 +59,6 @@ public static void main(String[] args) throws IOException, InterruptedException,
                 .setTracerProvider(tracerProvider)
                 .buildAndRegisterGlobal();
 
-        Tracer tracer = openTelemetry.getTracer("Microsoft.DurableTask");
         logger.info("OpenTelemetry configured with OTLP exporter at " + otlpEndpoint);
 
         // Build connection string for DTS emulator
@@ -149,29 +139,17 @@ public TaskOrchestration create() {
         DurableTaskClient client = DurableTaskSchedulerClientExtensions
                 .createClientBuilder(connectionString).build();
 
-        // Create a parent span — the SDK automatically propagates W3C trace context
-        Span orchestrationSpan = tracer.spanBuilder("create_orchestration:FanOutFanIn")
-                .setAttribute("durabletask.task.name", "FanOutFanIn")
-                .setAttribute("durabletask.type", "orchestration")
-                .startSpan();
-
-        orchestrationContext = Context.current().with(orchestrationSpan);
-
-        String instanceId;
-        try (Scope scope = orchestrationSpan.makeCurrent()) {
-            logger.info("Scheduling FanOutFanIn orchestration...");
-            instanceId = client.scheduleNewOrchestrationInstance(
-                    "FanOutFanIn",
-                    new NewOrchestrationInstanceOptions().setInput("weather-request"));
-            orchestrationSpan.setAttribute("durabletask.task.instance_id", instanceId);
-            logger.info("Started orchestration: " + instanceId);
-        }
+        // The SDK automatically creates a create_orchestration span and propagates W3C trace context
+        logger.info("Scheduling FanOutFanIn orchestration...");
+        String instanceId = client.scheduleNewOrchestrationInstance(
+                "FanOutFanIn",
+                new NewOrchestrationInstanceOptions().setInput("weather-request"));
+        logger.info("Started orchestration: " + instanceId);
 
         // Wait for completion
         logger.info("Waiting for completion...");
         OrchestrationMetadata result = client.waitForInstanceCompletion(
                 instanceId, Duration.ofSeconds(60), true);
-        orchestrationSpan.end();
 
         logger.info("Status: " + result.getRuntimeStatus());
         logger.info("Result: " + result.readOutputAs(String.class));