updated tests

Author: bachuv

endtoendtests/src/main/java/com/functions/RewindTest.java

@@ -71,8 +71,10 @@ public HttpResponseMessage startRewindableOrchestration(
 
     /**
      * HTTP trigger that starts a non-failing orchestration, waits for it to complete,
-     * then attempts to rewind it using client.rewindInstance(). Returns the check status
-     * response so the caller can verify the orchestration remains in the Completed state.
+     * then attempts to rewind it using client.rewindInstance(). The sidecar should reject
+     * the rewind with FAILED_PRECONDITION (translated to IllegalStateException) since
+     * the instance is not in a Failed state. Returns 200 with the exception message on
+     * expected rejection, or 500 if the rewind unexpectedly succeeded.
      */
     @FunctionName("StartRewindNonFailedOrchestration")
     public HttpResponseMessage startRewindNonFailedOrchestration(
@@ -104,12 +106,16 @@ public HttpResponseMessage startRewindNonFailedOrchestration(
         // in a Failed state. The client translates this to an IllegalStateException.
         try {
             client.rewindInstance(instanceId, "Testing rewind on non-failed orchestration");
-            context.getLogger().info("Rewind request sent for non-failed instance: " + instanceId);
+            // If we get here, the rewind did not throw as expected
+            return request.createResponseBuilder(com.microsoft.azure.functions.HttpStatus.INTERNAL_SERVER_ERROR)
+                    .body("IllegalStateException was not thrown for non-failed instance")
+                    .build();
         } catch (IllegalStateException e) {
             context.getLogger().info("Rewind on non-failed instance was rejected (expected): " + e.getMessage());
+            return request.createResponseBuilder(com.microsoft.azure.functions.HttpStatus.OK)
+                    .body(e.getMessage())
+                    .build();
         }
-
-        return durableContext.createCheckStatusResponse(request, instanceId);
     }
 
     /**

endtoendtests/src/test/java/com/functions/EndToEndTests.java

@@ -270,20 +270,16 @@ public void rewindNonExistentOrchestration() throws InterruptedException {
     @Test
     public void rewindNonFailedOrchestration() throws InterruptedException {
         // Start a non-failing orchestration - the trigger waits for completion
-        // and then calls client.rewindInstance() internally before returning
+        // and then calls client.rewindInstance() internally before returning.
+        // The rewind should be rejected with IllegalStateException since the
+        // instance is not in a Failed state.
         String startOrchestrationPath = "/api/StartRewindNonFailedOrchestration";
         Response response = post(startOrchestrationPath);
-        JsonPath jsonPath = response.jsonPath();
-        String statusQueryGetUri = jsonPath.get("statusQueryGetUri");
-
-        // Wait a few seconds to allow any potential state change from the rewind attempt
-        Thread.sleep(5000);
-
-        // Verify the orchestration remains in Completed state (rewind should have no effect)
-        Response statusResponse = get(statusQueryGetUri);
-        String status = statusResponse.jsonPath().get("runtimeStatus");
-        assertEquals("Completed", status,
-                "Orchestration should remain Completed after rewind attempt on a non-failed instance");
+        assertEquals(200, response.getStatusCode(),
+                "Expected 200 OK indicating the IllegalStateException was caught. Body: " + response.getBody().asString());
+        String body = response.getBody().asString();
+        assertTrue(body.contains("is not in a failed state") && body.contains("cannot be rewound"),
+                "Response should contain the precondition error message, but was: " + body);
     }
 
     @Test