Remove rewind tests from standalone SDK and keep Functions e2e tests

Author: bachuv

CHANGELOG.md

@@ -1,6 +1,6 @@
 ## Unreleased
 
-* Adding rewind client API ([#253](https://github.com/microsoft/durabletask-java/pull/253))
+* Adding rewind client API ([#253](https://github.com/microsoft/durabletask-java/pull/253)). Note: orchestration processing for rewind is supported with Azure Functions but not with the standalone `GrpcDurableTaskWorker`.
 
 ## v1.7.0
 * Add descriptive error when orchestration type is not registered ([#261](https://github.com/microsoft/durabletask-java/pull/261))

client/src/main/java/com/microsoft/durabletask/DurableTaskClient.java

@@ -299,6 +299,10 @@ public abstract OrchestrationMetadata waitForInstanceCompletion(
      * When rewound, the orchestration instance will restart from the point of failure as if the failure
      * never occurred. It rewinds the orchestration by replaying any
      * Failed Activities and Failed suborchestrations that themselves have Failed Activities
+     * <p>
+     * <b>Note:</b> Rewind requires a backend that supports it. When using Azure Functions with the
+     * Durable Task extension, rewind is fully supported. The standalone {@code GrpcDurableTaskWorker}
+     * does not currently support orchestration processing for rewind.
      *
      * @param instanceId the ID of the orchestration instance to rewind
      */
@@ -313,6 +317,10 @@ public void rewindInstance(String instanceId) {
      * When rewound, the orchestration instance will restart from the point of failure as if the failure
      * never occurred. It rewinds the orchestration by replaying any
      * Failed Activities and Failed suborchestrations that themselves have Failed Activities
+     * <p>
+     * <b>Note:</b> Rewind requires a backend that supports it. When using Azure Functions with the
+     * Durable Task extension, rewind is fully supported. The standalone {@code GrpcDurableTaskWorker}
+     * does not currently support orchestration processing for rewind.
      *
      * @param instanceId the ID of the orchestration instance to rewind
      * @param reason the reason for rewinding the orchestration instance

client/src/main/java/com/microsoft/durabletask/DurableTaskGrpcClient.java

@@ -343,17 +343,6 @@ public PurgeResult purgeInstances(PurgeInstanceCriteria purgeInstanceCriteria) t
         }
     }
 
-    @Override
-    public void rewindInstance(String instanceId, @Nullable String reason) {
-        Helpers.throwIfArgumentNull(instanceId, "instanceId");
-        RewindInstanceRequest.Builder rewindRequestBuilder = RewindInstanceRequest.newBuilder();
-        rewindRequestBuilder.setInstanceId(instanceId);
-        if (reason != null) {
-            rewindRequestBuilder.setReason(StringValue.of(reason));
-        }
-        this.sidecarClient.rewindInstance(rewindRequestBuilder.build());
-    }
-
     @Override
     public void suspendInstance(String instanceId, @Nullable String reason) {
         SuspendRequest.Builder suspendRequestBuilder = SuspendRequest.newBuilder();
@@ -374,6 +363,17 @@ public void resumeInstance(String instanceId, @Nullable String reason) {
         this.sidecarClient.resumeInstance(resumeRequestBuilder.build());
     }
 
+    @Override
+    public void rewindInstance(String instanceId, @Nullable String reason) {
+        Helpers.throwIfArgumentNull(instanceId, "instanceId");
+        RewindInstanceRequest.Builder rewindRequestBuilder = RewindInstanceRequest.newBuilder();
+        rewindRequestBuilder.setInstanceId(instanceId);
+        if (reason != null) {
+            rewindRequestBuilder.setReason(StringValue.of(reason));
+        }
+        this.sidecarClient.rewindInstance(rewindRequestBuilder.build());
+    }
+
     @Override
     public String restartInstance(String instanceId, boolean restartWithNewInstanceId) {
         OrchestrationMetadata metadata = this.getInstanceMetadata(instanceId, true);

client/src/test/java/com/microsoft/durabletask/IntegrationTests.java

@@ -413,56 +413,6 @@ void subOrchestration() throws TimeoutException {
         }
     }
 
-    @Test
-    void subOrchestrationWithFailedActivity() throws TimeoutException {
-        final String parentOrchestratorName = "ParentOrchestration";
-        final String childOrchestratorName = "ChildOrchestration";
-        final String activityName = "FailingActivity";
-        final String failureMessage = "Simulated activity failure in sub-orchestration";
-        final String expectedOutput = "Success after rewind";
-        final AtomicBoolean shouldFail = new AtomicBoolean(true);
-
-        DurableTaskGrpcWorker worker = this.createWorkerBuilder()
-                .addOrchestrator(parentOrchestratorName, ctx -> {
-                    String result = ctx.callSubOrchestrator(childOrchestratorName, null, String.class).await();
-                    ctx.complete(result);
-                })
-                .addOrchestrator(childOrchestratorName, ctx -> {
-                    String result = ctx.callActivity(activityName, null, String.class).await();
-                    ctx.complete(result);
-                })
-                .addActivity(activityName, ctx -> {
-                    if (shouldFail.compareAndSet(true, false)) {
-                        throw new RuntimeException(failureMessage);
-                    }
-                    return expectedOutput;
-                })
-                .buildAndStart();
-
-        DurableTaskClient client = this.createClientBuilder().build();
-        try (worker; client) {
-            String instanceId = client.scheduleNewOrchestrationInstance(parentOrchestratorName);
-
-            // Wait for the orchestration to fail due to the activity failure in the sub-orchestration
-            OrchestrationMetadata instance = client.waitForInstanceCompletion(instanceId, defaultTimeout, true);
-            assertNotNull(instance);
-            assertEquals(OrchestrationRuntimeStatus.FAILED, instance.getRuntimeStatus());
-
-            FailureDetails details = instance.getFailureDetails();
-            assertNotNull(details);
-            assertTrue(details.getErrorMessage().contains(failureMessage));
-
-            // Rewind the failed orchestration
-            client.rewindInstance(instanceId, "Rewinding sub-orchestration with failed activity");
-
-            // Wait for the orchestration to complete after rewind
-            instance = client.waitForInstanceCompletion(instanceId, defaultTimeout, true);
-            assertNotNull(instance);
-            assertEquals(OrchestrationRuntimeStatus.COMPLETED, instance.getRuntimeStatus());
-            assertEquals(expectedOutput, instance.readOutputAs(String.class));
-        }
-    }
-
     @Test
     void continueAsNew() throws TimeoutException {
         final String orchestratorName = "continueAsNew";
@@ -655,107 +605,6 @@ void terminateSuspendOrchestration() throws TimeoutException, InterruptedExcepti
         }
     }
 
-    private void rewindFailedOrchestrationHelper(String rewindReason) throws TimeoutException {
-        final String orchestratorName = "RewindOrchestration" + (rewindReason == null ? "NoReason" : "");
-        final String activityName = "FailOnceActivity" + (rewindReason == null ? "NoReason" : "");
-        final String expectedOutput = "Success after rewind" + (rewindReason == null ? " without reason" : "");
-        final AtomicBoolean shouldFail = new AtomicBoolean(true);
-
-        DurableTaskGrpcWorker worker = this.createWorkerBuilder()
-                .addOrchestrator(orchestratorName, ctx -> {
-                    String result = ctx.callActivity(activityName, null, String.class).await();
-                    ctx.complete(result);
-                })
-                .addActivity(activityName, ctx -> {
-                    if (shouldFail.compareAndSet(true, false)) {
-                        throw new RuntimeException("Simulated transient failure");
-                    }
-                    return expectedOutput;
-                })
-                .buildAndStart();
-
-        DurableTaskClient client = this.createClientBuilder().build();
-        try (worker; client) {
-            String instanceId = client.scheduleNewOrchestrationInstance(orchestratorName);
-
-            // Wait for the orchestration to fail
-            OrchestrationMetadata instance = client.waitForInstanceCompletion(instanceId, defaultTimeout, false);
-            assertNotNull(instance);
-            assertEquals(OrchestrationRuntimeStatus.FAILED, instance.getRuntimeStatus());
-
-            // Rewind the failed orchestration
-            if (rewindReason != null) {
-                client.rewindInstance(instanceId, rewindReason);
-            } else {
-                client.rewindInstance(instanceId);
-            }
-
-            // Wait for the orchestration to complete after rewind
-            instance = client.waitForInstanceCompletion(instanceId, defaultTimeout, true);
-            assertNotNull(instance);
-            assertEquals(OrchestrationRuntimeStatus.COMPLETED, instance.getRuntimeStatus());
-            assertEquals(expectedOutput, instance.readOutputAs(String.class));
-        }
-    }
-
-    @Test
-    void rewindFailedOrchestration() throws TimeoutException {
-        rewindFailedOrchestrationHelper("Rewinding after transient failure");
-    }
-
-    @Test
-    void rewindFailedOrchestrationWithoutReason() throws TimeoutException {
-        rewindFailedOrchestrationHelper(null);
-    }
-
-    @Test
-    void rewindCompletedOrchestrationThrowsException() throws TimeoutException {
-        final String orchestratorName = "RewindCompletedOrchestration";
-
-        DurableTaskGrpcWorker worker = this.createWorkerBuilder()
-                .addOrchestrator(orchestratorName, ctx -> {
-                    ctx.complete("Completed successfully");
-                })
-                .buildAndStart();
-
-        DurableTaskClient client = this.createClientBuilder().build();
-        try (worker; client) {
-            String instanceId = client.scheduleNewOrchestrationInstance(orchestratorName);
-
-            // Wait for the orchestration to complete
-            OrchestrationMetadata instance = client.waitForInstanceCompletion(instanceId, defaultTimeout, true);
-            assertNotNull(instance);
-            assertEquals(OrchestrationRuntimeStatus.COMPLETED, instance.getRuntimeStatus());
-
-            // Attempt to rewind a completed orchestration - should throw or be a no-op
-            // Based on API behavior, rewind is only valid for FAILED orchestrations
-            assertThrows(
-                Exception.class,
-                () -> client.rewindInstance(instanceId, "Attempting to rewind completed orchestration"),
-                "Rewinding a completed orchestration should throw an exception"
-            );
-        }
-    }
-
-    @Test
-    void rewindNonExistentOrchestrationThrowsException() {
-        final String orchestratorName = "RewindNonExistent";
-        final String nonExistentId = "non-existent-instance-id";
-
-        DurableTaskGrpcWorker worker = this.createWorkerBuilder()
-                .addOrchestrator(orchestratorName, ctx -> ctx.complete("done"))
-                .buildAndStart();
-
-        DurableTaskClient client = this.createClientBuilder().build();
-        try (worker; client) {
-            assertThrows(
-                Exception.class,
-                () -> client.rewindInstance(nonExistentId, "Attempting to rewind non-existent orchestration"),
-                "Rewinding a non-existent orchestration should throw an exception"
-            );
-        }
-    }
-
     @Test
     void activityFanOut() throws IOException, TimeoutException {
         final String orchestratorName = "ActivityFanOut";