From 29c59b5284d22772a4089e590fd3a546d56609b7 Mon Sep 17 00:00:00 2001
From: "omar.mahamid" <omar.taiseerr@gmail.com>
Date: Sat, 16 Nov 2024 13:54:27 +0200
Subject: [PATCH 1/3] enhance cosine similarity

---
 .../data/vectorsearch/VectorOperations.java      | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
index cbc1e314..cabf91ea 100644
--- a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
+++ b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
@@ -38,15 +38,17 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
             throw new SKException("Vectors lengths must be equal");
         }
 
-        float dotProduct = dot(x, y);
-        float normX = dot(x, x);
-        float normY = dot(y, y);
-
-        if (normX == 0 || normY == 0) {
-            throw new SKException("Vectors cannot have zero norm");
+        double dotProduct = 0.0;
+        double normX = 0.0;
+        double normY = 0.0;
+
+        for (int i = 0; i < x.size(); i++) {
+            dotProduct += x.get(i) * y.get(i);
+            normX += x.get(i) * x.get(i);
+            normY += y.get(i) * y.get(i);
         }
 
-        return dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY));
+        return (float) (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
     }
 
     /**

From 4c9c2190a090f4f061bd65ccfc6b90f08f67830f Mon Sep 17 00:00:00 2001
From: "omar.mahamid" <omar.taiseerr@gmail.com>
Date: Sat, 16 Nov 2024 13:58:19 +0200
Subject: [PATCH 2/3] float instead of double

---
 .../data/vectorsearch/VectorOperations.java               | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
index cabf91ea..b43f990b 100644
--- a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
+++ b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
@@ -38,9 +38,9 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
             throw new SKException("Vectors lengths must be equal");
         }
 
-        double dotProduct = 0.0;
-        double normX = 0.0;
-        double normY = 0.0;
+        float dotProduct = 0.0F;
+        float normX = 0.0F;
+        float normY = 0.0F;
 
         for (int i = 0; i < x.size(); i++) {
             dotProduct += x.get(i) * y.get(i);
@@ -48,7 +48,7 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
             normY += y.get(i) * y.get(i);
         }
 
-        return (float) (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
+        return (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
     }
 
     /**

From 49e5ff58199d0442078a48b564a189c5927fb0c7 Mon Sep 17 00:00:00 2001
From: "omar.mahamid" <omar.taiseerr@gmail.com>
Date: Sat, 16 Nov 2024 14:01:40 +0200
Subject: [PATCH 3/3] Update VectorOperations.java

---
 .../semantickernel/data/vectorsearch/VectorOperations.java    | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
index b43f990b..ba86cb7b 100644
--- a/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
+++ b/semantickernel-api/src/main/java/com/microsoft/semantickernel/data/vectorsearch/VectorOperations.java
@@ -48,6 +48,10 @@ public static float cosineSimilarity(@Nonnull List<Float> x, @Nonnull List<Float
             normY += y.get(i) * y.get(i);
         }
 
+        if (normX == 0 || normY == 0) {
+            throw new SKException("Vectors cannot have zero norm");
+        }
+
         return (dotProduct / (float) (Math.sqrt(normX) * Math.sqrt(normY)));
     }