From 7501d23e1bd2de141d68887385310c03541504ba Mon Sep 17 00:00:00 2001 From: Phil Jirsa Date: Thu, 27 Feb 2025 08:43:00 -0600 Subject: [PATCH 1/2] update opentelemetry span attributes --- .../implementation/telemetry/ChatCompletionSpan.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/semantickernel-api/src/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java b/semantickernel-api/src/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java index 87945860..9fa465ed 100644 --- a/semantickernel-api/src/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java +++ b/semantickernel-api/src/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java @@ -104,8 +104,8 @@ public void endSpanWithUsage(ChatCompletions chatCompletions) { CompletionsUsage usage = chatCompletions.getUsage(); getSpan().setStatus(StatusCode.OK); getSpan() - .setAttribute("gen_ai.response.completion_tokens", usage.getCompletionTokens()); - getSpan().setAttribute("gen_ai.response.prompt_tokens", usage.getPromptTokens()); + .setAttribute("gen_ai.usage.output_tokens", usage.getCompletionTokens()); + getSpan().setAttribute("gen_ai.usage.input_tokens", usage.getPromptTokens()); close(); } From 016aa2220f61610a713c98fe88dd4f0c24132273 Mon Sep 17 00:00:00 2001 From: Phil Jirsa Date: Sun, 2 Mar 2025 07:48:33 -0600 Subject: [PATCH 2/2] update otel test --- .../semantickernel/aiservices/openai/OtelCaptureTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/aiservices/openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java b/aiservices/openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java index c9136c55..5c3444b3 100644 --- a/aiservices/openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java +++ b/aiservices/openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java @@ -118,9 +118,9 @@ public void otelChatCaptureTest() { spans.get(0).getAttributes().get(AttributeKey.stringKey("gen_ai.system"))); Assertions.assertEquals(21, spans.get(0).getAttributes() - .get(AttributeKey.longKey("gen_ai.response.completion_tokens"))); + .get(AttributeKey.longKey("gen_ai.usage.output_tokens"))); Assertions.assertEquals(42, spans.get(0).getAttributes() - .get(AttributeKey.longKey("gen_ai.response.prompt_tokens"))); + .get(AttributeKey.longKey("gen_ai.usage.input_tokens"))); } }