Skip to content

Theme Review #42

@grappler

Description

@grappler

As I was doing the PR #41 I saw a few things that could be improved.

  • As the image size handles are not prefixed they could class with a plugin if it had the same handle.
    https://github.com/mor10/simone/blob/master/functions.php#L60-64
  • You should be using only one option in the database. The settings should be saved in a single array. So the setting would be simon_settings and everything would be saved in there. The problem is in line 35 of customizer.php It should be 'simon_settings[simone_header_color]'
  • The setting output should be escaped in simone_customizer_css().
  • There is no use for simon.mo. It can be deleted.

Metadata

Metadata

Assignees

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions