Skip to content
This repository was archived by the owner on Feb 26, 2020. It is now read-only.
This repository was archived by the owner on Feb 26, 2020. It is now read-only.

Stop guessing the GeckoProfiler API #51

@tarekziade

Description

@tarekziade

Why are we doing guesswork here by counting the number of arguments the API has ?

https://github.com/mozilla/browsertime/blob/master/lib/firefox/webdriver/firefoxDelegate.js#L54-L74
this leads to a fragile implementation, that gets broken everytime the API is changed, see #50

we should explicitely look at the firefox version and implement the right script for each supported Firefox version (and also throw a hard error in case it's not implemented. no need to go further like we do now)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions