From 7ff0481445ff59b3ea6e88137d0667a2d3239ffb Mon Sep 17 00:00:00 2001 From: Davey Alvarez Date: Wed, 11 Feb 2026 13:48:39 -0800 Subject: [PATCH] fix(subscription-reminders): Fix misconfigured subscription reminder args Because: * the code to autogenerate the variable names changed, but the references did not commit: * Updates the references to the autogenerated variables, and includes an explicit check for these values Closes #N/A --- .../fxa-auth-server/lib/payments/subscription-reminders.ts | 6 ++++++ packages/fxa-auth-server/scripts/subscription-reminders.ts | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/fxa-auth-server/lib/payments/subscription-reminders.ts b/packages/fxa-auth-server/lib/payments/subscription-reminders.ts index 7dbd65b83a2..cdab0acff47 100644 --- a/packages/fxa-auth-server/lib/payments/subscription-reminders.ts +++ b/packages/fxa-auth-server/lib/payments/subscription-reminders.ts @@ -40,6 +40,7 @@ interface EndingRemindersOptions { } interface RenewalRemindersOptions { + monthlyReminderDays?: number; yearlyReminderDays?: number; } @@ -81,6 +82,11 @@ export class SubscriptionReminders { this.statsd = statsd; this.planDuration = Duration.fromObject({ days: planLength }); this.reminderDuration = Duration.fromObject({ days: reminderLength }); + if (renewalRemindersOptions.monthlyReminderDays) { + this.reminderDuration = Duration.fromObject({ + days: renewalRemindersOptions.monthlyReminderDays, + }); + } if (renewalRemindersOptions.yearlyReminderDays) { this.yearlyRenewalReminderDuration = Duration.fromObject({ days: renewalRemindersOptions.yearlyReminderDays, diff --git a/packages/fxa-auth-server/scripts/subscription-reminders.ts b/packages/fxa-auth-server/scripts/subscription-reminders.ts index de9cdd10637..a47ffe7a647 100644 --- a/packages/fxa-auth-server/scripts/subscription-reminders.ts +++ b/packages/fxa-auth-server/scripts/subscription-reminders.ts @@ -87,7 +87,7 @@ async function init() { const subscriptionReminders = new SubscriptionReminders( log, parseInt(program.planLength), - parseInt(program.reminderLength), + parseInt(program.monthlyRenewalReminderLength), { enabled: parseBooleanArg(program.enableEndingReminders), paymentsNextUrl: config.smtp.subscriptionSettingsUrl, @@ -96,6 +96,7 @@ async function init() { yearlyReminderDays: parseInt(program.endingReminderYearlyLength), }, { + monthlyReminderDays: parseInt(program.monthlyRenewalReminderLength), yearlyReminderDays: parseInt(program.yearlyRenewalReminderLength), }, database,