From b1f1ee2929eaa274e2153ff081a2950bfef16b8f Mon Sep 17 00:00:00 2001 From: Matt Blaha Date: Sat, 7 Jan 2017 17:03:05 -0600 Subject: [PATCH 1/3] Increase timeout value and better hand timeout errors. (#25) --- phantom-scrape.js | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/phantom-scrape.js b/phantom-scrape.js index d1c1ce5..63c202b 100644 --- a/phantom-scrape.js +++ b/phantom-scrape.js @@ -72,7 +72,13 @@ if (userAgent) { page.settings.loadImages = false; // ensure we don't waste time trying to load slow/missing resources -page.settings.resourceTimeout = 1000; +page.settings.resourceTimeout = 5000; + +// if we do timeout a slow resource, say something useful +page.onResourceTimeout = function(request) { + console.log('Response (#' + request.id + '): ' + JSON.stringify(request)); + phantom.exit(1); +}; page.onConsoleMessage = function(msg) { consoleLogs.push(msg); From 3e3d366f516e57a00f45670681305a304caeba2d Mon Sep 17 00:00:00 2001 From: Matt Blaha Date: Sat, 7 Jan 2017 18:13:31 -0600 Subject: [PATCH 2/3] Remove exit call from onResourceTimeout. (#25) --- phantom-scrape.js | 1 - 1 file changed, 1 deletion(-) diff --git a/phantom-scrape.js b/phantom-scrape.js index 63c202b..f172e0f 100644 --- a/phantom-scrape.js +++ b/phantom-scrape.js @@ -77,7 +77,6 @@ page.settings.resourceTimeout = 5000; // if we do timeout a slow resource, say something useful page.onResourceTimeout = function(request) { console.log('Response (#' + request.id + '): ' + JSON.stringify(request)); - phantom.exit(1); }; page.onConsoleMessage = function(msg) { From d871579184e6e2b4bfa9a53f283a6211981ef776 Mon Sep 17 00:00:00 2001 From: Matt Blaha Date: Mon, 9 Jan 2017 02:58:57 -0600 Subject: [PATCH 3/3] Write to stderr rather than stdout with console.log. (#25) --- phantom-scrape.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/phantom-scrape.js b/phantom-scrape.js index f172e0f..e8517c9 100644 --- a/phantom-scrape.js +++ b/phantom-scrape.js @@ -76,7 +76,7 @@ page.settings.resourceTimeout = 5000; // if we do timeout a slow resource, say something useful page.onResourceTimeout = function(request) { - console.log('Response (#' + request.id + '): ' + JSON.stringify(request)); + require("system").stderr.write('Response (#' + request.id + '): ' + JSON.stringify(request)); }; page.onConsoleMessage = function(msg) {