Skip to content

"transformed_result" property of AbstractResultExtractor has several types #45

@lucmurer

Description

@lucmurer

The "transformed_result" property of AbstractResultExtractor has inconsistent types depending on the subclass:

  • In "AbstractHostResultExtractor" it is Dict[str, NutsResult]
  • In "AbstractHostDestResultExtractor" it is Dict[str, Dict[str, NutsResult]]

To me this is an issue due to the following reasons:

  1. The transformed result is a public interface property of the class, at least intended to be used in the per-test created "Extractor" subclass. This could pose a source of confusion
  2. Static type checking is undermined or at least made difficult with these two options.

Possible Solutions to this:

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions